Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: remove value field from token - OKTA-338251 #515

Merged
merged 2 commits into from
Oct 29, 2020
Merged

feat: remove value field from token - OKTA-338251 #515

merged 2 commits into from
Oct 29, 2020

Conversation

shuowu
Copy link
Contributor

@shuowu shuowu commented Oct 20, 2020

As this PR changes the token type, it still looks like a breaking change.

@aarongranick-okta
Copy link
Contributor

As this PR changes the token type, it still looks like a breaking change.

Please base the branch/PR against the dev-5.0 branch.

@shuowu shuowu changed the base branch from master to dev-5.0 October 20, 2020 17:25
@shuowu-okta shuowu-okta deleted the branch dev-5.0 October 21, 2020 16:54
@shuowu shuowu reopened this Oct 21, 2020
@shuowu shuowu changed the base branch from dev-5.0 to master October 21, 2020 16:56
@shuowu shuowu changed the base branch from master to dev-5.0 October 21, 2020 16:56
@aarongranick-okta
Copy link
Contributor

@shuowu what happened to the dev-5.0 branch? I am seeing that it is even with master. It should have package.json bumped to version 5.0.0

@shuowu
Copy link
Contributor Author

shuowu commented Oct 21, 2020

@shuowu what happened to the dev-5.0 branch? I am seeing that it is even with master. It should have package.json bumped to version 5.0.0

I re-created it since your last one has the memory change in. I'll bump the version from dev-5.0

@shuowu shuowu changed the base branch from dev-5.0 to master October 21, 2020 18:05
@shuowu-okta shuowu-okta force-pushed the sw-remove-token-value-field-OKTA-338251 branch from fcb2d40 to 3063c9f Compare October 21, 2020 18:08
@shuowu shuowu changed the base branch from master to dev-5.0 October 21, 2020 18:08
@aarongranick-okta aarongranick-okta mentioned this pull request Oct 28, 2020
Closed
@shuowu shuowu requested a review from swiftone October 28, 2020 21:39
@shuowu-okta shuowu-okta merged commit b00271f into dev-5.0 Oct 29, 2020
aarongranick-okta pushed a commit that referenced this pull request Mar 10, 2021
@shuowu @aarongranick-okta
feat: remove value field from token - OKTA-338251 (#515)
c4eaa07
aarongranick-okta pushed a commit that referenced this pull request Apr 2, 2021
@shuowu @aarongranick-okta
feat: remove value field from token - OKTA-338251 (#515)
33ac9d1
aarongranick-okta pushed a commit that referenced this pull request Apr 14, 2021
@shuowu @aarongranick-okta
feat: remove value field from token - OKTA-338251 (#515)
ad422b7
aarongranick-okta pushed a commit that referenced this pull request Apr 20, 2021
@shuowu @aarongranick-okta
feat: remove value field from token - OKTA-338251 (#515)
e3954e1
eng-prod-CI-bot-okta pushed a commit that referenced this pull request Apr 20, 2021
@shuowu @eng-prod-CI-bot-okta
feat: remove value field from token - OKTA-338251 (#515)
2308f17 
OKTA-388545
<<<Jenkins Check-In of Tested SHA: 6842f2a for eng_productivity_ci_bot_okta@okta.com>>>
Artifact: okta-auth-js
Files changed count: 252
@Primajin
Copy link

Primajin commented Jun 25, 2021 •
edited
Loading

May I ask what the reasoning behind this change was since I can't read your OKTA-338251. And the workaround / migration should look like?

EDIT: I mean can I for example do accessToken?.accessToken instead of accessToken?.value - or is that a different token?

@shuowu
Copy link
Contributor Author

shuowu commented Jun 25, 2021

@Primajin It's the same. the value field is removed to fix size limit issue for cookie storage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swiftone swiftone swiftone approved these changes

@aarongranick-okta aarongranick-okta Awaiting requested review from aarongranick-okta

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@shuowu @aarongranick-okta @Primajin @swiftone @shuowu-okta