sets useInteractionCodeFlow to true in samples and test app
#1062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev-6 #1062 +/- ##
==========================================
+ Coverage 92.51% 92.59% +0.07%
==========================================
Files 134 134
Lines 3743 3739 -4
Branches 791 791
==========================================
- Hits 3463 3462 -1
+ Misses 280 277 -3
Continue to review full report at Codecov.
|
aarongranick-okta
force-pushed
the
dev-6
branch
from
362285b
to
d209c7c
Compare
aarongranick-okta
force-pushed
the
ag-OKTA-458192-oie-default
branch
from
264fe75
to
c1d715c
Compare
shuowu
approved these changes
Jan 14, 2022
| @@ -49,7 +49,7 @@ import { | |||
| transactionStatus, | |||
| resumeTransaction, | |||
| transactionExists, | |||
| introspect, | |||
| introspectAuthn, | |||
There was a problem hiding this comment.
looks like a breaking change, add to changelog?
There was a problem hiding this comment.
yes, I guess it would technically be a breaking change if anyone was importing { introspect } from @okta/okta-auth-js. Hopefully nobody is doing this and everyone is using authClient.tx.introspect. I'll add a note in changelog.
aarongranick-okta
force-pushed
the
ag-OKTA-458192-oie-default
branch
2 times, most recently
from
37b3c53
to
bdc24b8
Compare
adds dynamic signin form to spa samples sets IdxFeature enum to use human readable strings export all idx, rename old introspect to introspectAuthn
aarongranick-okta
force-pushed
the
ag-OKTA-458192-oie-default
branch
from
bdc24b8
to
b419bd2
Compare
eng-prod-CI-bot-okta
pushed a commit
that referenced
this pull request
Jan 19, 2022
adds dynamic signin form to spa samples sets IdxFeature enum to use human readable strings export all idx, rename old introspect to introspectAuthn OKTA-458192 <<<Jenkins Check-In of Tested SHA: b419bd2 for eng_productivity_ci_bot_okta@okta.com>>> Artifact: okta-auth-js Files changed count: 51 PR Link: "#1062"
aarongranick-okta
added a commit
that referenced
this pull request
Jan 19, 2022
adds dynamic signin form to spa samples sets IdxFeature enum to use human readable strings export all idx, rename old introspect to introspectAuthn OKTA-458192 <<<Jenkins Check-In of Tested SHA: b419bd2 for eng_productivity_ci_bot_okta@okta.com>>> Artifact: okta-auth-js Files changed count: 51 PR Link: "#1062"
aarongranick-okta
added a commit
that referenced
this pull request
Jan 19, 2022
adds dynamic signin form to spa samples sets IdxFeature enum to use human readable strings export all idx, rename old introspect to introspectAuthn OKTA-458192 <<<Jenkins Check-In of Tested SHA: b419bd2 for eng_productivity_ci_bot_okta@okta.com>>> Artifact: okta-auth-js Files changed count: 51 PR Link: "#1062"
jaredperreault-okta
pushed a commit
that referenced
this pull request
Jan 20, 2022
adds dynamic signin form to spa samples sets IdxFeature enum to use human readable strings export all idx, rename old introspect to introspectAuthn OKTA-458192 <<<Jenkins Check-In of Tested SHA: b419bd2 for eng_productivity_ci_bot_okta@okta.com>>> Artifact: okta-auth-js Files changed count: 51 PR Link: "#1062"
jaredperreault-okta
pushed a commit
that referenced
this pull request
Jan 20, 2022
adds dynamic signin form to spa samples sets IdxFeature enum to use human readable strings export all idx, rename old introspect to introspectAuthn OKTA-458192 <<<Jenkins Check-In of Tested SHA: b419bd2 for eng_productivity_ci_bot_okta@okta.com>>> Artifact: okta-auth-js Files changed count: 51 PR Link: "#1062"
aarongranick-okta
added a commit
that referenced
this pull request
Jan 20, 2022
adds dynamic signin form to spa samples sets IdxFeature enum to use human readable strings export all idx, rename old introspect to introspectAuthn OKTA-458192 <<<Jenkins Check-In of Tested SHA: b419bd2 for eng_productivity_ci_bot_okta@okta.com>>> Artifact: okta-auth-js Files changed count: 51 PR Link: "#1062"
eng-prod-CI-bot-okta
pushed a commit
that referenced
this pull request
Jan 20, 2022
adds dynamic signin form to spa samples sets IdxFeature enum to use human readable strings export all idx, rename old introspect to introspectAuthn OKTA-458192 <<<Jenkins Check-In of Tested SHA: b419bd2 for eng_productivity_ci_bot_okta@okta.com>>> Artifact: okta-auth-js Files changed count: 51 PR Link: "#1062" OKTA-383487 <<<Jenkins Check-In of Tested SHA: f1b290b for eng_productivity_ci_bot_okta@okta.com>>> Artifact: okta-auth-js Files changed count: 235 PR Link: "#1053"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
flowtoauthMethodto avoid confusion with the IDX flowIdxFeature