refactor: only use esm import syntax #1114
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Codecov Report
@@ Coverage Diff @@
## master #1114 +/- ##
=======================================
Coverage 93.51% 93.51%
=======================================
Files 154 154
Lines 4147 4149 +2
Branches 906 907 +1
=======================================
+ Hits 3878 3880 +2
Misses 253 253
Partials 16 16
Continue to review full report at Codecov.
|
| @@ -247,6 +245,10 @@ var storageUtil: BrowserStorageUtil = { | |||
| }, | |||
|
|
|||
| get: function(name: string): string { | |||
| // return all cookies when no args is provided | |||
There was a problem hiding this comment.
If name is optional, should the method signature be:
get: function(name?: string): string
jaredperreault-okta
approved these changes
Feb 28, 2022
shuowu-okta
force-pushed
the
sw-only-use-import-syntax
branch
from
83c7ef0
to
17237f4
Compare
test/apps/react-oie/vite.config.js
Outdated
|
|
||
| const env = {}; | ||
| // List of environment variables made available to the app | ||
| ['ISSUER', 'CLIENT_ID'].forEach((key) => { |
There was a problem hiding this comment.
include 'SPA_CLIENT_ID' for consistency across other sdks
aarongranick-okta
approved these changes
Mar 2, 2022
add cjs bundle validation test use vite for react-oie test app adjust rollup config for development generate esm node bundle add exports field as guiduice of different envs
shuowu-okta
force-pushed
the
sw-only-use-import-syntax
branch
from
17237f4
to
0dcad6d
Compare
eng-prod-CI-bot-okta
pushed a commit
that referenced
this pull request
Mar 3, 2022
add cjs bundle validation test use vite for react-oie test app adjust rollup config for development generate esm node bundle add exports field as guiduice of different envs OKTA-405564 <<<Jenkins Check-In of Tested SHA: 0dcad6d for eng_productivity_ci_bot_okta@okta.com>>> Artifact: okta-auth-js Files changed count: 38 PR Link: "#1114"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #1073
viteinstead ofCRAfor react-oie test app, now it's faster dev experience and able to test (discover issues) ESM moduleDownstream tests (green):