remove require syntax #1061
Closed
remove require syntax #1061
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OKTA-419985 <<<Jenkins Check-In of Tested SHA: a793ce8 for eng_productivity_ci_bot_okta@okta.com>>> Artifact: okta-auth-js Files changed count: 3 PR Link: "#1003"
OKTA-407553 <<<Jenkins Check-In of Tested SHA: 1125253 for eng_productivity_ci_bot_okta@okta.com>>> Artifact: okta-auth-js Files changed count: 6 PR Link: "#1049"
OKTA-419417 <<<Jenkins Check-In of Tested SHA: 6e7feb9 for eng_productivity_ci_bot_okta@okta.com>>> Artifact: okta-auth-js Files changed count: 8 PR Link: "#1050"
email verify callback contains otp parameter adds new option withCredentials adds new option codeChallenge pass authenticator if password is provided up front use jasmine framework in wdio improve layout in test app add more time for token renew tests prefer login direct, avoid issue with popup OKTA-454796 add exchangeCodeForTokens option loosen remediate restrictions on default flow update samples throw exceptions from run (breaking change) consolidate idx interface under the idx namespace activationToken and recoveryToken as config option OKTA-449647 <<<Jenkins Check-In of Tested SHA: 7f54738 for eng_productivity_ci_bot_okta@okta.com>>> Artifact: okta-auth-js Files changed count: 90 PR Link:
OKTA-428455 <<<Jenkins Check-In of Tested SHA: 3dad085 for eng_productivity_ci_bot_okta@okta.com>>> Artifact: okta-auth-js Files changed count: 9 PR Link: "#1051"
This reverts commit d053eee. OKTA-460241 <<<Jenkins Check-In of Tested SHA: bf894c2 for eng_productivity_ci_bot_okta@okta.com>>> Artifact: okta-auth-js Files changed count: 3 PR Link: "#1056"
…to true OKTA-459787 <<<Jenkins Check-In of Tested SHA: 3bb06dc for eng_productivity_ci_bot_okta@okta.com>>> Artifact: okta-auth-js Files changed count: 7 PR Link: "#1059"
aarongranick-okta
force-pushed
the
dev-6
branch
from
362285b
to
d209c7c
Compare
shuowu-okta
force-pushed
the
sw-remove-require-syntax
branch
from
2d5017e
to
035a209
Compare
jaredperreault-okta
approved these changes
Jan 14, 2022
OKTA-459135 <<<Jenkins Check-In of Tested SHA: d1acf90 for eng_productivity_ci_bot_okta@okta.com>>> Artifact: okta-auth-js Files changed count: 114 PR Link: "#1057"
by upgrading to 3.x, which supports cjs and esm
transform and bundle p-cancelable in the esm bundle
Codecov Report
@@ Coverage Diff @@
## dev-6 #1061 +/- ##
==========================================
+ Coverage 92.51% 93.20% +0.68%
==========================================
Files 134 134
Lines 3743 3693 -50
Branches 791 783 -8
==========================================
- Hits 3463 3442 -21
+ Misses 280 251 -29
Continue to review full report at Codecov.
|
shuowu-okta
force-pushed
the
sw-remove-require-syntax
branch
from
286371a
to
0f3caf6
Compare
aarongranick-okta
force-pushed
the
dev-6
branch
from
390189f
to
5c0f8b9
Compare
aarongranick-okta
force-pushed
the
dev-6
branch
2 times, most recently
from
c9e222e
to
f1b290b
Compare
|
👋 Thanks for fixing this! Assuming this is a fix for #1073, is there a timeline for when this would get merged in? This is work blocking and would love to get this released asap. |
|
Closing this draft PR, track #1114 for ESM fix progress. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.