Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support EC private keys for OAuth service apps #329

Closed
wants to merge 5 commits into from
Closed

feat: support EC private keys for OAuth service apps #329

wants to merge 5 commits into from

Conversation

oleksandrpravosudko-okta
Copy link
Contributor

@oleksandrpravosudko-okta oleksandrpravosudko-okta commented May 27, 2022 •
edited
Loading

  • use Eckles library for PEM<->JWK conversion of EC keys
  • allow passing kid through keyId through configuration properties

OKTA-496997

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Adding Tests
  • Build related changes
  • CI related changes
  • Documentation changes
  • Other... Please describe:

What is the current behavior?

Issue Number: #324

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Reviewers

@oleksandrpravosudko-okta oleksandrpravosudko-okta force-pushed the op-okta-496997-ec-key-support branch from b91ac79 to 337ccad Compare May 27, 2022 21:07
eng-prod-CI-bot-okta pushed a commit that referenced this pull request May 31, 2022
@oleksandrpravosudko-okta @eng-prod-CI-bot-okta
feat: support EC private keys for OAuth service apps
fd0462d 
OKTA-496997
<<<Jenkins Check-In of Tested SHA: 2114435 for eng_productivity_ci_bot_okta@okta.com>>>
Artifact: okta-sdk-nodejs
Files changed count: 11
PR Link: #329
denysoblohin-okta added a commit that referenced this pull request Jan 25, 2023
@denysoblohin-okta @oleksandrpravosudko-okta @releng-internal-okta
Update oas3 branch to master (#372)
f9bd7c2 
* feat: support EC private keys for OAuth service apps

OKTA-496997
<<<Jenkins Check-In of Tested SHA: 2114435 for eng_productivity_ci_bot_okta@okta.com>>>
Artifact: okta-sdk-nodejs
Files changed count: 11
PR Link: #329

* Releng: Revving up to version(s) 6.6.0 for artifact(s) okta-sdk-nodejs

* Update dependencies (#357)

* add mocha inline reporter (#354) (#366)

OKTA-554035 add mocha inline reporter (#354)

* fix: export MemoryStore through library root, update MemoryStore.get type signature (#364)

OKTA-550323 fix: export MemoryStore through library root, update MemoryStore.get type signature

Co-authored-by: Denys Oblohin <72614880+denysoblohin-okta@users.noreply.github.com>

* fix: allow custom attributes for extensible types (#365)

OKTA-550323 fix: allow custom attributes for extensible types

* Releng: Revving up to version(s) 6.7.0 for artifact(s) okta-sdk-nodejs

* Merge remote-tracking branch 'origin/master' into oas-v3-update-to-master



Co-authored-by: Oleksandr Pravosudko <oleksandr.pravosudko@okta.com>
Co-authored-by: releng-internal-okta <eng_releng_internal@okta.com>
Co-authored-by: Oleksandr Pravosudko <71440851+oleksandrpravosudko-okta@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shuowu shuowu shuowu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@oleksandrpravosudko-okta @shuowu @eng-prod-CI-bot-2-okta