Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow custom attributes for extensible types #365

Merged
merged 8 commits into from
Dec 7, 2022

Conversation

oleksandrpravosudko-okta
Copy link
Contributor

@oleksandrpravosudko-okta oleksandrpravosudko-okta commented Nov 25, 2022

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Adding Tests
  • Build related changes
  • CI related changes
  • Documentation changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Reviewers

@oleksandrpravosudko-okta oleksandrpravosudko-okta force-pushed the extensible-models-custom-attributes branch 4 times, most recently from f366132 to 449b5b3 Compare December 6, 2022 14:07
@oleksandrpravosudko-okta oleksandrpravosudko-okta marked this pull request as ready for review December 6, 2022 15:53
@oleksandrpravosudko-okta oleksandrpravosudko-okta force-pushed the extensible-models-custom-attributes branch from 6b68773 to d781f2c Compare December 7, 2022 16:09
@eng-prod-CI-bot-2-okta eng-prod-CI-bot-2-okta merged commit 0956b83 into master Dec 7, 2022
denysoblohin-okta added a commit that referenced this pull request Jan 25, 2023
* feat: support EC private keys for OAuth service apps

OKTA-496997
<<<Jenkins Check-In of Tested SHA: 2114435 for eng_productivity_ci_bot_okta@okta.com>>>
Artifact: okta-sdk-nodejs
Files changed count: 11
PR Link: #329

* Releng: Revving up to version(s) 6.6.0 for artifact(s) okta-sdk-nodejs

* Update dependencies (#357)

* add mocha inline reporter (#354) (#366)

OKTA-554035 add mocha inline reporter (#354)

* fix: export MemoryStore through library root, update MemoryStore.get type signature (#364)

OKTA-550323 fix: export MemoryStore through library root, update MemoryStore.get type signature

Co-authored-by: Denys Oblohin <72614880+denysoblohin-okta@users.noreply.github.com>

* fix: allow custom attributes for extensible types (#365)

OKTA-550323 fix: allow custom attributes for extensible types

* Releng: Revving up to version(s) 6.7.0 for artifact(s) okta-sdk-nodejs

* Merge remote-tracking branch 'origin/master' into oas-v3-update-to-master



Co-authored-by: Oleksandr Pravosudko <oleksandr.pravosudko@okta.com>
Co-authored-by: releng-internal-okta <eng_releng_internal@okta.com>
Co-authored-by: Oleksandr Pravosudko <71440851+oleksandrpravosudko-okta@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants