Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Okta Push broken #263

Merged
merged 1 commit into from
Jan 16, 2019
Merged

Conversation

AlainODea
Copy link
Contributor

Problem Statement

Issue #262 states:

Describe the bug
After validateStatus(jsonObjResponse); was added to verifyAnswer in #250, it started failing on push challenge requests with this error:

Push Factor Authentication
Exception in thread "main" java.lang.IllegalStateException: Handling for the received status code is not currently implemented.
The status code received was:
MFA_CHALLENGE: The user must verify the factor-specific challenge. POST to the verify link relation to verify the factor.

To Reproduce
Steps to reproduce the behavior:

1. Call

2. Request Push authentication

3. See the error

Expected behavior
It should work, as it did before the latest version.

Solution

  • Consider the MFA_CHALLENGE acceptable to pass on to downstream code

Resolves #262

 - Consider the MFA_CHALLENGE acceptable to pass on to downstream code

Resolves oktadev#262
@AlainODea
Copy link
Contributor Author

@vbabenkoru thank you for offering to test this. I think this should fix it. Please approve if it does.

@AlainODea
Copy link
Contributor Author

@vbabenkoru how did your testing on this go? Does it fix the issue for you?

@vbabenkoru
Copy link

Compiled the branch and tested - looks like MFA is working now! Thanks!

@AlainODea AlainODea merged commit 6afdf9f into oktadev:master Jan 16, 2019
@ktham
Copy link

ktham commented Jan 17, 2019

@AlainODea would you be able to cut a 1.0.8 release with this fix soon?

@AlainODea
Copy link
Contributor Author

AlainODea commented Jan 17, 2019

@ktham I'll do that shortly. This is a pretty serious flaw. I'll note it on the v1.0.7 release as a regression right away.
UPDATE: correct typo on release number

@AlainODea
Copy link
Contributor Author

@ktham v1.0.8 is released:

@ktham
Copy link

ktham commented Jan 17, 2019

Thank you so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants