Feature/authn-error-handling-during-browser-flow #267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bogeylnj
changed the title
bogeylnj
force-pushed
the
feature/authn-error-handling-and-MFA_CHALLENGE-state
branch
from
3b51d74 to
878044a
Compare
|
Code looks good. I'll test this now and pending that, approve and merge. Thanks again. |
|
Thank you for your contribution, @bogeylnj :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Edited for rebasing)
Problem Statement
If the runtime environment is missing a certificate, the Okta dialog would popup and hang with no feedback (SSL handshake failure).
Solution
Add an error property change listener to print error message for User (could throw Exception if wouldn't disrupt other workflows)