Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fixes shell arguments being passed twice to aws command #377

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

hcourse-nydig
Copy link

@hcourse-nydig hcourse-nydig commented Aug 4, 2021

Removes first param from arg lists before calling aws cli. Fixes both bash and fish

Resolves: #375
Resolves: #376

Removes first param from arg lists before calling aws cli. Fixes both bash and fish

Resolves: oktadev#375, oktadev#376
@dangeReis
Copy link
Contributor

dangeReis commented Aug 4, 2021

Actually I believe this is wrong. This works, but only coincidentally. I believe it will not resolve #374

The issue is that the new install script (https://github.com/oktadev/okta-aws-cli-assume-role/blob/master/bin/install.sh) lost lines 135-142 from here

command="\$1"
profile=\$2
shift;
shift;
if [ "$1" == "logout" ]
then
command="logout"
fi
It's possible that the java bits changed to receive different arguments, but something needs to write the proper profile name into the .aws/credentials file.

@dangeReis
Copy link
Contributor

Looks like this is the commit that broke things.

63b8809#diff-0bb30e60c9060eae4f3b622c188c4ed97bc18c04242404cd8a9a4098961082e4

@DavidTanner was this change intentional? It seems to have broken things.

@dangeReis
Copy link
Contributor

@hcourse-nydig I combined what you did with what @DavidTanner did in #380. Can you review and let me know if that works in fish?

@mraible
Copy link

mraible commented Mar 29, 2022

If you're still interested in seeing this merged, please fix conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fish scripts appear to be broken (Fix in comment) okta-aws passing profile name twice to aws CLI
3 participants