Added additional commands #290
Conversation
|
I think you are always sending HTTP commands, even if the library is in telnet control mode. Or did I miss something here? |
Indeed I am not aware (yet) on how the library works. I added only HTTP commands. Is it the same command names for telnet ? |
|
Hi again, I added corresponding commands for telnet protocole according to this documentation |
|
H @ol-iver, do you intend to merge the PR soon ? |
|
I like the idea, thanks for your PR 🚀 |
|
Hi, I have updated formatting |
denonavr/const.py
Outdated
| command_cusor_up=COMMAND_CURSOR_UP, | ||
| command_cusor_down=COMMAND_CURSOR_DOWN, | ||
| command_cusor_left=COMMAND_CURSOR_LEFT, | ||
| command_cusor_right=COMMAND_CURSOR_RIGHT, | ||
| command_cusor_enter=COMMAND_CURSOR_ENTER, | ||
| command_back=COMMAND_BACK, | ||
| command_info=COMMAND_INFO, | ||
| command_options=COMMAND_OPTIONS, | ||
| command_setup_open=COMMAND_SETUP_OPEN, | ||
| command_setup_close=COMMAND_SETUP_CLOSE, | ||
| command_setup_query=COMMAND_SETUP_QUERY |
There was a problem hiding this comment.
These lines should be added to ZONE2_URLS and ZONE3_URLS too.
This might be the reason why the tests are failing.
| @@ -535,6 +535,87 @@ async def async_power_off(self) -> None: | |||
| else: | |||
| await self.api.async_get_command(self.urls.command_power_standby) | |||
|
|
|||
| async def async_cursor_up(self) -> None: | |||
There was a problem hiding this comment.
Please call each of your new functions from DenonAVR class like in this example. Otherwise the methods won't be publicly accessible.
|
Hi, I have added the missing commands (unit testings passed this time) and added public methods |
|
Thanks 🙂 |
|
Hi @ol-iver, I have applied the merge. It should be okay this time :) |
|
There are still a couple of linting issues 😅 |
|
Hi,
I missed one of the formatting tasks. It should be (hopefully) ok this time
I have a question : are you sure that telnet is faster than HTTP commands ? It may be my setup but I find volume up/down more reactive with http commands
Thanks
Damien
De : Oliver ***@***.***>
Envoyé : jeudi 2 mai 2024 10:12
À : ol-iver/denonavr ***@***.***>
Cc : albaintor ***@***.***>; Author ***@***.***>
Objet : Re: [ol-iver/denonavr] Added additional commands (PR #290)
There are still a couple of linting issues 😅
Unless you contributed for the first time, Github does not start the tests automatically. Thus is would make sense if you run the code-format<https://github.com/ol-iver/denonavr/blob/c70e8ce11cd1f9ef86053201588d41d1f63b6e14/.github/workflows/python-code-format.yml#L31-L42> and the integration tests<https://github.com/ol-iver/denonavr/blob/c70e8ce11cd1f9ef86053201588d41d1f63b6e14/.github/workflows/python-tests.yml#L34-L36> locally.
—
Reply to this email directly, view it on GitHub<#290 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/A4IHILAXQEKOZRI274DLJD3ZAHYOLAVCNFSM6AAAAABEZHF6YWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOBZHA3DINBWGM>.
You are receiving this because you authored the thread.Message ID: ***@***.******@***.***>>
|
|
There was still an issue. I fixed the last one by myself. The main advantage of telnet is that the properties of your receiver are updated immediately, even when you are pressing buttons on your remote control. When you use HTTP you have to poll for updates with |
|
Thanks for your work 🚀 |
Added additional commands for AVR : cursor pad, settings and option menu, info as requested in #289