-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added additional commands #290
Merged
Merged
Changes from 5 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
642581a
Added additional commands
albaintor f55ff03
Added corresponding telnet commands for additional commands (HTTP GET…
albaintor 1868d13
Fix
albaintor 987cd3b
Menu open : replaced telnet by http command to get menu status
albaintor b17edc8
Fix formatting
albaintor ffe58fa
Fixed testings with missing commands and added public methods
albaintor a518163
Merge branch 'main' into main
albaintor 3ad2e7c
Fixed merge since removal of sync methods
albaintor b7bb975
Fixed merge since removal of sync methods
albaintor 67d4f11
Fixed formating
albaintor f3dcf0c
Format with `black`
ol-iver File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -535,6 +535,87 @@ async def async_power_off(self) -> None: | |
else: | ||
await self.api.async_get_command(self.urls.command_power_standby) | ||
|
||
async def async_cursor_up(self) -> None: | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Please call each of your new functions from |
||
"""Cursor Up on receiver via HTTP get command.""" | ||
if self.telnet_available: | ||
await self.telnet_api.async_send_commands( | ||
self.telnet_commands.command_cusor_up | ||
) | ||
else: | ||
await self.api.async_get_command(self.urls.command_cusor_up) | ||
|
||
async def async_cursor_down(self) -> None: | ||
"""Cursor Down on receiver via HTTP get command.""" | ||
if self.telnet_available: | ||
await self.telnet_api.async_send_commands( | ||
self.telnet_commands.command_cusor_down | ||
) | ||
else: | ||
await self.api.async_get_command(self.urls.command_cusor_down) | ||
|
||
async def async_cursor_left(self) -> None: | ||
"""Cursor Left on receiver via HTTP get command.""" | ||
if self.telnet_available: | ||
await self.telnet_api.async_send_commands( | ||
self.telnet_commands.command_cusor_left | ||
) | ||
else: | ||
await self.api.async_get_command(self.urls.command_cusor_left) | ||
|
||
async def async_cursor_right(self) -> None: | ||
"""Cursor Right on receiver via HTTP get command.""" | ||
if self.telnet_available: | ||
await self.telnet_api.async_send_commands( | ||
self.telnet_commands.command_cusor_right | ||
) | ||
else: | ||
await self.api.async_get_command(self.urls.command_cusor_right) | ||
|
||
async def async_cursor_enter(self) -> None: | ||
"""Cursor Enter on receiver via HTTP get command.""" | ||
if self.telnet_available: | ||
await self.telnet_api.async_send_commands( | ||
self.telnet_commands.command_cusor_enter | ||
) | ||
else: | ||
await self.api.async_get_command(self.urls.command_cusor_enter) | ||
|
||
async def async_back(self) -> None: | ||
"""Back command on receiver via HTTP get command.""" | ||
if self.telnet_available: | ||
await self.telnet_api.async_send_commands(self.telnet_commands.command_back) | ||
else: | ||
await self.api.async_get_command(self.urls.command_back) | ||
|
||
async def async_info(self) -> None: | ||
"""Info OSD on receiver via HTTP get command.""" | ||
if self.telnet_available: | ||
await self.telnet_api.async_send_commands(self.telnet_commands.command_info) | ||
else: | ||
await self.api.async_get_command(self.urls.command_info) | ||
|
||
async def async_options(self) -> None: | ||
"""Options menu on receiver via HTTP get command.""" | ||
await self.api.async_get_command(self.urls.command_options) | ||
|
||
async def async_settings_menu(self) -> None: | ||
"""Options menu on receiver via HTTP get command.""" | ||
res = await self.api.async_get_command(self.urls.command_setup_query) | ||
if self.telnet_available: | ||
if res is not None and res == "MNMEN ON": | ||
await self.telnet_api.async_send_commands( | ||
self.telnet_commands.command_setup_close | ||
) | ||
else: | ||
await self.telnet_api.async_send_commands( | ||
self.telnet_commands.command_setup_open | ||
) | ||
else: | ||
if res is not None and res == "MNMEN ON": | ||
await self.api.async_get_command(self.urls.command_setup_close) | ||
else: | ||
await self.api.async_get_command(self.urls.command_setup_open) | ||
|
||
|
||
@attr.s(auto_attribs=True, on_setattr=DENON_ATTR_SETATTR) | ||
class DenonAVRFoundation: | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These lines should be added to
ZONE2_URLS
andZONE3_URLS
too.This might be the reason why the tests are failing.