Fixed crash on loading an organ with a crescendo in Add mode GrandOrg…

…ue#1772
oleg68 · Jan 26, 2024 · 52ea274 · 52ea274
1 parent 15dac59
commit 52ea274
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 0 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,4 @@
+- Fixed crash on loading an organ with a crescendo in Add mode https://github.com/GrandOrgue/grandorgue/issues/1772
 - Added support of specifying different crossfade length for additional attack and release files https://github.com/GrandOrgue/grandorgue/issues/1760
 - Fixed wrong filename of the midi recorder file with Hungarian language settings https://github.com/GrandOrgue/grandorgue/issues/1644
 - Fixed unability to select the Hungarian language in the Organ Settings dialog

diff --git a/src/grandorgue/combinations/model/GOCombination.cpp b/src/grandorgue/combinations/model/GOCombination.cpp
@@ -215,6 +215,8 @@ void GOCombination::SetStatesFromYaml(
 void GOCombination::GetExtraSetState(
   GOCombination::ExtraElementsSet &extraSet) {
   extraSet.clear();
+  // May be called from init a crescendo before init combinations
+  EnsureElementStatesAllocated();
   for (unsigned i = 0; i < r_ElementDefinitions.size(); i++) {
     if (
       m_ElementStates[i] == 0