forked from ember-cli/broccoli-builder
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Diff from branch-point to 0-18-x #6
Open
oligriffiths
wants to merge
97
commits into
branch-point
Choose a base branch
from
0-18-x
base: branch-point
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* print plugin annotation * print instantiation stack * print original stack
Improve errors thrown during build
…ich will make it easier to find their source location.
Add instantiation stack
We should likely, once merged back into mainline split up broccoli into several more modules, so consumers can choose what they need, and leave broccoli itself as the union of the core add-ons, for quick starts
Remove stuff we don’t use, when using broccoli as a lib.
This lets us query them properly in slowtrees
…ppropriate analysis
Use structured logging
Bump heimdalljs
The [npmjs.org site](https://www.npmjs.com/package/ember-cli-broccoli) links to github.com/broccolijs/broccoli for the `ember-cli-broccoli` package. This change to package.json should make it so that npmjs.org links here instead.
Update github repo, homepage in package.json
disable jshint
Ensure mid-build cleanups cancel and cleanup partial work
It actually makes stuff worse, as the new BroccoliBuildError stuff handles this correctly.
Remove now defunct error message improving code.
Update test suite to mocha
Remove BROCCOLI_WARN_READ_API env var and always warn on old .read/.rebuild api
Use __broccoliGetInfo__() to get plugin/node name/label
Revert "Use __broccoliGetInfo__() to get plugin/node name/label"
…-plugin-name Use getNodeInfo() to get plugin/node name/label"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the diff from the common root
ab404ef725be5c265c901838be40d0358a867ec4
that the broccoli-builder branch point from where it started diverging frommaster