Test shortlog #79
Closed
Test shortlog #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Separate scheduler commands from the main scheduler code. * Put all commands behind a decorator to protect against leakage. (e.g. an import cannot be mistaken for a command/validator). * Integrate command validators in with the commands themselves. This removes the duplicate command/validate function signatures and makes validators implicit (i.e. they are called as part of the command not searched for and called separately to the command). * Make all commands async and provide a blank validator for each (i.e. add a yield at the top of each function). Note this means that command args/kwargs are now validated as part of queueing the command itself by default. * Partially addresses cylc#3329 by making commands generators capable of returning multiple messages. * Improve interface for multi-workflow commands: - Colour formatting for success/error cases. - One line per workflow (presuming single line output). - Exceptions in processing one workflow's response caught and logged rather than interrupting other workflow's output. - Commands exit 1 if any workflow returns an error response. * Add multi-workflow test for "cylc broadcast".
Command validation
* SSH->TCP client was missing the `ssh forward environment variables` key. * This PR gives it an empty placeholder value for now.
client: fix SSH client
If you don't close DB connections when you're done with them, I will scream
Fix xtrigger `sequential` arg validation & improve docs
* This is testing remote-fileinstallation but the test was configured to run on hosts with shared filesystems where remote-fileinstallation is not required
* Testing job log retrieval which requires a non-shared filesystem
Workflow: Release stage 1 - create release PR (Cylc 8+ only), run: 37
Prepare release: 8.3.0
Workflow: Release stage 2 - auto publish, run: 77 Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
* The arpa address returned by `socket.getfqdn` on Mac OS is different with Python 3.9 than 3.7 (conda-forge).
Fix flaky integration tests
It was possible for taskProxies when doing 'cylc show' to be in an odd order: Task ID: 20240728T0000Z/b Task ID: 20240727T0000Z/b Task ID: 20240729T0000Z/b After this change, they are always sorted by the ID of the task: Task ID: 20240727T0000Z/b Task ID: 20240728T0000Z/b Task ID: 20240729T0000Z/b
Sort cylc show task proxies
Skip some failing functional tests on MacOS GH Actions runner
…interactive upgrade (cylc#6267) Ensure reinvocation works for interactively upgraded workflow
Demote "timer stopped" warning to info & fix functional tests `contains_ok` function
Functional tests: fix unbound env var failure
* Closes cylc#6291 * The `cylc play` command would sometimes produce traceback when detaching workflows (the default unless `--no-detach` is used). * This traceback does not appear to have had any ill effects, but may have suppressed the normal Python session teardown logic. * It was only reported on Mac OS, but may potentially occur on other systems. * This PR mitigates the circumstances under which the traceback occurred by separating the asyncio event loops that are run before and after daemonization.
GH Actions: include hidden files when uploading `~/cylc-run` artifact
…thout having to call it
play: fix spurious traceback observed on some systems
Prevent a couple of unit tests from installing into `~/cylc-run`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.