-
Notifications
You must be signed in to change notification settings - Fork 877
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Histogram Collection Creates Errors on Each Scrape With Older Redis Versions #784
Comments
Thank for opening this issue.
I'm leaning towards 3. - what do you think? |
I would be inclined toward the 3rd option, as well. I'm sure there would be advantages toward the 2nd, but it sounds like a lot of unnecessary work, and the 1st sounds finicky, since you might hit some transient error and disable it accidentally. |
Makes sense. |
2 option is right way. redis_version present in "info all"
|
@gzivdo that looks like the best fix, is there a possibility to get this merged please? |
@tdewolff - if you submit a PR I can have a look and review it to get it merged. |
ping? |
@oliver006 I see your comment #847 (comment)
for us for example it's an issue as it generate Errors (redis_errors_total metric) for each exporter every time (not only in the beginning) and it prevents us to make normal alerts |
Hmm, interesting, I agree that's not optimal (it shouldn't generate an error the first time it happens). |
I think option 3 is much better than generate 1 error at start
|
Describe the problem
When running redis 6.x, the new histogram metrics cause Redis error counter to increase on every scrape, even though the error message logged is limited to one.
It would be convenient to have a way to disable the new histogram via ENV or automatically if the command is failing.
What version of redis_exporter are you running?
Please run
redis_exporter --version
if you're not sure what version you're running.[ ] 0.3x.x
[x] 1.48+
Running the exporter
What's the full command you're using to run the exporter? (please remove passwords and other sensitive data)
Expected behavior
Testing an upgrade from an older version to the newest versions. Expected things to continue working, with new metrics available.
Screenshots
Periods where error counter is increasing are running v1.49, and when it is stable are v1.47
Additional context
The text was updated successfully, but these errors were encountered: