Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Add option to skip collecting latency histogram metrics #911

Closed

Conversation

Nklya
Copy link
Contributor

@Nklya Nklya commented May 27, 2024

I will try to add tests later, PTAL in terms of naming and style.

It fixes: #784 via 3rd option you mentioned here #784 (comment)

@coveralls
Copy link

Pull Request Test Coverage Report for Build 353

Details

  • 3 of 78 (3.85%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.07%) to 84.172%

Changes Missing Coverage Covered Lines Changed/Added Lines %
main.go 0 75 0.0%
Totals Coverage Status
Change from base Build 350: -0.07%
Covered Lines: 1973
Relevant Lines: 2344

💛 - Coveralls

@oliver006
Copy link
Owner

Approach looks good.
Naming nit: in this PR #906 we used exclude-...-metrics, here it's skip-...-metrics - let's use exclude for both?

…6#906)

* Feature: Add option to exclude consumer from Stream metrics
@Nklya Nklya force-pushed the feature-add-option-skip-histogram branch from 65c7786 to 3b3906c Compare May 30, 2024 21:34
@Nklya Nklya closed this May 30, 2024
@Nklya Nklya deleted the feature-add-option-skip-histogram branch May 30, 2024 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New Histogram Collection Creates Errors on Each Scrape With Older Redis Versions
4 participants