Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Memoizer API updates #3820

Closed
melissalinkert opened this issue May 6, 2022 · 1 comment · Fixed by #3958
Closed

Memoizer API updates #3820

melissalinkert opened this issue May 6, 2022 · 1 comment · Fixed by #3958
Labels
enhancement New feature or request

Comments

@melissalinkert
Copy link
Member

See glencoesoftware/bioformats2raw#145 (comment)
@melissalinkert melissalinkert added the enhancement New feature or request label May 6, 2022
@sbesson
Copy link
Member

sbesson commented May 9, 2022

Looking at https://github.com/glencoesoftware/bioformats2raw/blob/ac99da5b4fa6a8e28a4a52d3c88474f3fd22b122/src/main/java/com/glencoesoftware/bioformats2raw/Converter.java#L723-L740, a few thoughts:

  • should

    bioformats/components/formats-bsd/src/loci/formats/Memoizer.java

    Lines 508 to 512 in 6ef3227

    public Memoizer(IFormatReader r, long minimumElapsed, File directory) {
    super(r);
    this.minimumElapsed = minimumElapsed;
    this.directory = directory;
    }
    be updated to support null reader input? All other constructors could be delegate to this single implementation.
  • do we need a public Memoizer(IFormatReader r, File directory) constructor?

melissalinkert added a commit to melissalinkert/bioformats that referenced this issue Mar 6, 2023
@melissalinkert
Memoizer: minor API updates
a272d6a 
Fixes ome#3820.

This allows a null reader to be specified in the constructors, in which case a
new ImageReader will be wrapped. The memo file can also now be deleted and retrieved
from public methods.
@melissalinkert melissalinkert mentioned this issue Mar 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Memoizer: minor API updates melissalinkert/bioformats
2 participants
@melissalinkert @sbesson