Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete memo files by default #145

Merged

Conversation

melissalinkert
Copy link
Member

Fixes #136

There are 3 cases covered here:

  • --keep-memo-files is used; no memo files will be deleted
  • memo file is not created, either because a valid memo file existed before bioformats2raw was run or the initialization time was too short; no memo files will be deleted
  • memo file was created and --keep-memo-files is not used; memo file will be deleted at the end of conversion

The test is turned off at the moment as I need to figure out a way to force memo file creation for fake files (see ome/bioformats#3804).

--keep-memo-files disables memo file deletion. If the memo file existed
before conversion started, it shouldn't be deleted either way.

Fixes glencoesoftware#136
@sbesson
Copy link
Member

sbesson commented Apr 20, 2022

I expect the just-released Bio-Formats 6.9.1 artifacts should allow to activate the unit tests

@joshmoore
Copy link
Contributor

Other than that this points to improvements for the Memoizer API (accept null arguments, allow deleting the memo file, etc.), this logic makes sense to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Delete existing memo files by default?
4 participants