Fake: move configurable sleep to the end of initFile #3804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If it's at the beginning of initFile, then the sleep happens before `sleepInitFile` can be parsed.
melissalinkert
added a commit
to melissalinkert/bioformats2raw
that referenced
this pull request
Mar 31, 2022
Turned off for now due to ome/bioformats#3804
sbesson
approved these changes
Apr 4, 2022
There was a problem hiding this comment.
Makes complete sense.
Without this PR
build@6a7f00715965:~$ /bio-formats-build/bioformats/tools/showinf -nopix "test&sleepInitFile=1000.fake" | grep Initi
Initializing reader
Initialization took 0.094s
build@6a7f00715965:~$ /bio-formats-build/bioformats/tools/showinf -nopix "test&sleepInitFile=1000.fake" | grep Initi
Initializing reader
Initialization took 0.088s
build@6a7f00715965:~$ /bio-formats-build/bioformats/tools/showinf -nopix "test&sleepInitFile=1000.fake" | grep Initi
Initializing reader
Initialization took 0.091s
With this PR included
build@ae500cd2a479:~$ /bio-formats-build/bioformats/tools/showinf -nopix "test&sleepInitFile=1000.fake" | grep Initi
Initializing reader
Initialization took 1.116s
build@ae500cd2a479:~$ /bio-formats-build/bioformats/tools/showinf -nopix "test&sleepInitFile=1000.fake" | grep Initi
Initializing reader
Initialization took 1.087s
build@ae500cd2a479:~$ /bio-formats-build/bioformats/tools/showinf -nopix "test&sleepInitFile=1000.fake" | grep Initi
Initializing reader
Initialization took 1.094s
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If it's at the beginning of initFile, then the sleep happens before
sleepInitFilecan be parsed.Noticed while trying to write a test for glencoesoftware/bioformats2raw#136.
Compare
showinf test&sleepInitFile=1000.fakewith and without this PR; with this PR, the printed initialization time should be approximately 1 second longer.