-
Notifications
You must be signed in to change notification settings - Fork 242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Actions on PR and tag #3626
Actions on PR and tag #3626
Conversation
Did you investigate any existing actions e.g. https://github.com/actions/create-release https://github.com/actions/upload-release-asset ? |
@manics I have played with both of them, yes but opted for the solution put in place due to the steps required like creation of checksum etc. |
A few comments:
|
I think:
since we push over 10 artifacts and not having support for loop in actions, using upstream actions was making the file extremely long, and this chosen approach was not breaking if for example we decide to remove a jar. As indicated I will remove it for now and we can revisit when the deployment is in place. |
closing this PR see #3635 for the build part of this work |
Add support for actions.
Build on windows and ubuntu on pull_request
When a tag is pushed, the artifacts will be uploaded to the GitHub tag (similar to downloads.o.org)
I have not removed the hard-coded version for this round
Token will need to set on the repo in order to push the tag
I have not removed the travis or appeyvor files
I have tested the workflow using on my account see https://github.com/jburel/bioformats/releases/tag/v6.6.0-m3 for example
cc @dgault