-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Actions #4
Actions #4
Conversation
Related to ome/omero-marshal#70 (comment), is this repository supposed to be the place to build and maintain the Ice wheels for all our supported Python distributions? If so I could certainly see adding Python 3.9 as follow-up.
Also cross-linking to ome/bioformats#3626 (comment) and ome/zeroc-ice-ubuntu2004#1 (comment) where these discussions started. I won't have the capacity to assess the action so happy to trust your best judgement here with regard to consuming it across our repositories. |
Good point about 3.9, I will see what I can do |
https://github.com/jburel/zeroc-ice-py-manylinux/actions/runs/397152886 with Python 3.9 support |
The artifacts generated by the last commits were successfully tested in https://github.com/sbesson/omero-marshal/actions/runs/398022550. I assume there is only advantages to use these Portable Linux wheels? |
Main disadvantage is they contain a bundled static openssl library. Fine for testing, not so good for production use since they need to be recompiled to get openssl updates, especially if there's an upstream security fix. Also it means OMERO will be using two openssl libraries, the one bundled in this artifact and the one used by Python. |
This has come up before. Shall we consider deprecating these repos? |
last commit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No objections to deprecating these wheels with the same reasoning as the one raised in #4 (comment). Going further, we will need to collectively decide 1- whether this repository should have a final tag for Python 3.9, 2- more generally the set of Ice repositories we are actively supporting
For reference, a few organizational repositories are using the artifacts produced by this repository, primarily for testing purposes - see https://github.com/search?q=org%3Aome+zeroc-ice-py-manylinux&type=code. For testing, I can see two options:
- maintain wheels for all the combination of platforms/Python versions we need. In that case, the main need might be to support for all Python versions from 3.6 to 3.9 on Ubuntu. Places like https://github.com/search?q=org%3Aome+zeroc-ice-py-travis-bionic&type=code could also be updated
- leave GitHub actions installing Ice on the fly
Replace travis by actions
cc @sbesson
I think we need to discuss the release strategy,
The action
svenstaro/upload-release-action
simplifies greatly the release stepshttps://github.com/jburel/zeroc-ice-py-manylinux/actions/runs/396762415