Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actions #4

Merged
merged 10 commits into from
Dec 15, 2020
Merged

Actions #4

merged 10 commits into from
Dec 15, 2020

Conversation

jburel
Copy link
Member

@jburel jburel commented Dec 2, 2020

Replace travis by actions
cc @sbesson

I think we need to discuss the release strategy,
The action svenstaro/upload-release-action simplifies greatly the release steps

https://github.com/jburel/zeroc-ice-py-manylinux/actions/runs/396762415

@sbesson
Copy link
Member

sbesson commented Dec 2, 2020

Related to ome/omero-marshal#70 (comment), is this repository supposed to be the place to build and maintain the Ice wheels for all our supported Python distributions? If so I could certainly see adding Python 3.9 as follow-up.

I think we need to discuss the release strategy,
The action svenstaro/upload-release-action simplifies greatly the release steps

Also cross-linking to ome/bioformats#3626 (comment) and ome/zeroc-ice-ubuntu2004#1 (comment) where these discussions started. I won't have the capacity to assess the action so happy to trust your best judgement here with regard to consuming it across our repositories.

@jburel
Copy link
Member Author

jburel commented Dec 2, 2020

Good point about 3.9, I will see what I can do

@jburel
Copy link
Member Author

jburel commented Dec 3, 2020

@sbesson
Copy link
Member

sbesson commented Dec 3, 2020

The artifacts generated by the last commits were successfully tested in https://github.com/sbesson/omero-marshal/actions/runs/398022550. I assume there is only advantages to use these Portable Linux wheels?

@manics
Copy link
Member

manics commented Dec 3, 2020

Main disadvantage is they contain a bundled static openssl library. Fine for testing, not so good for production use since they need to be recompiled to get openssl updates, especially if there's an upstream security fix. Also it means OMERO will be using two openssl libraries, the one bundled in this artifact and the one used by Python.

Dockerfile Outdated Show resolved Hide resolved
@joshmoore
Copy link
Member

Main disadvantage is they contain a bundled static openssl library.

This has come up before. Shall we consider deprecating these repos?

@jburel
Copy link
Member Author

jburel commented Dec 3, 2020

Copy link
Member

@sbesson sbesson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No objections to deprecating these wheels with the same reasoning as the one raised in #4 (comment). Going further, we will need to collectively decide 1- whether this repository should have a final tag for Python 3.9, 2- more generally the set of Ice repositories we are actively supporting

For reference, a few organizational repositories are using the artifacts produced by this repository, primarily for testing purposes - see https://github.com/search?q=org%3Aome+zeroc-ice-py-manylinux&type=code. For testing, I can see two options:

@sbesson
Copy link
Member

sbesson commented Dec 15, 2020

@sbesson sbesson merged commit a40fdd7 into ome:master Dec 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants