Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from Travis CI to GitHub workflows #70

Merged
merged 7 commits into from
Dec 16, 2020
Merged

Conversation

sbesson
Copy link
Member

@sbesson sbesson commented Nov 30, 2020

  • add tox.ini configuration to run tests in multiple environments
  • set-up Tox and PyPI publication workflows
  • fix deprecated Pytest fixtures
  • remove Travis CI

See https://github.com/sbesson/omero-marshal/actions/runs/391224454 and https://github.com/sbesson/omero-marshal/actions/runs/391224455

- '3.6'
- '3.7'
- '3.8'
runs-on: ubuntu-18.04
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

20.04 is going to be the default shortly (ubuntu-latest). Any particular reason to pin to 18.04?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is mostly because we have precompiled Ice wheels for 3.6/3.7/3.8 for this environement used in tox.ini. Happy to switch if we have equivalent artifacts for Ubuntu 20.04 and the three Python versions

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3.9 should also exist now ;)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am fine with Python 3.6/3.7/3.8/3.9 on Ubuntu 20.04 too. Should all the wheels be generated as release artifacts of https://github.com/ome/zeroc-ice-ubuntu2004 then?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

miniconda is installed by default, we could skip these custom built wheels and use that instead?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For reference, https://github.com/sbesson/omero-marshal/actions/runs/393725465 is the result of the execution on Ubuntu 20.04, with Python 3.9 and without the custom wheels. The run time increased from ~1min to ~10min largely because of the installation of zeroc-ice but if we all agree this is acceptable, I can push the change to this PR

@sbesson
Copy link
Member Author

sbesson commented Dec 2, 2020

Looking at https://github.com/ome/omero-py/blob/v5.8.3/tox.ini and https://github.com/ome/omero-py/blob/v5.8.3/.github/workflows/workflow.yml, I realized that omero-py is actually running on Ubuntu 20.04 and using the wheels from https://github.com/ome/zeroc-ice-py-travis-bionic.

f3e48e3 re-enables these wheels for Python 3.6, 3.7 and 3.8 - see https://github.com/sbesson/omero-marshal/actions/runs/395673955

I could however use some clarification on:

  • whether we will keep supporting these wheels moving forward
  • if yes, whether we will build them for all supported Python versions - Actions zeroc-ice-ubuntu2004#1 for instance only creates one for the default Python on the platform

@sbesson
Copy link
Member Author

sbesson commented Dec 15, 2020

@sbesson sbesson requested a review from jburel December 15, 2020 15:46
Copy link
Member

@jburel jburel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on my fork.
Everything works as expected

@jburel jburel merged commit 5f690f9 into ome:master Dec 16, 2020
@sbesson sbesson deleted the ghactions branch December 16, 2020 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants