-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch from Travis CI to GitHub workflows #70
Conversation
.github/workflows/tox.yml
Outdated
- '3.6' | ||
- '3.7' | ||
- '3.8' | ||
runs-on: ubuntu-18.04 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
20.04 is going to be the default shortly (ubuntu-latest). Any particular reason to pin to 18.04?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is mostly because we have precompiled Ice wheels for 3.6/3.7/3.8 for this environement used in tox.ini
. Happy to switch if we have equivalent artifacts for Ubuntu 20.04 and the three Python versions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
3.9 should also exist now ;)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am fine with Python 3.6/3.7/3.8/3.9 on Ubuntu 20.04 too. Should all the wheels be generated as release artifacts of https://github.com/ome/zeroc-ice-ubuntu2004 then?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
miniconda is installed by default, we could skip these custom built wheels and use that instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For reference, https://github.com/sbesson/omero-marshal/actions/runs/393725465 is the result of the execution on Ubuntu 20.04, with Python 3.9 and without the custom wheels. The run time increased from ~1min to ~10min largely because of the installation of zeroc-ice
but if we all agree this is acceptable, I can push the change to this PR
Looking at https://github.com/ome/omero-py/blob/v5.8.3/tox.ini and https://github.com/ome/omero-py/blob/v5.8.3/.github/workflows/workflow.yml, I realized that omero-py is actually running on Ubuntu 20.04 and using the wheels from https://github.com/ome/zeroc-ice-py-travis-bionic. f3e48e3 re-enables these wheels for Python 3.6, 3.7 and 3.8 - see https://github.com/sbesson/omero-marshal/actions/runs/395673955 I could however use some clarification on:
|
Last commit consumes the wheels now built by https://github.com/ome/zeroc-ice-py-github-ci - see https://github.com/sbesson/omero-marshal/actions/runs/423553340 for the execution |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on my fork.
Everything works as expected
tox.ini
configuration to run tests in multiple environmentsSee https://github.com/sbesson/omero-marshal/actions/runs/391224454 and https://github.com/sbesson/omero-marshal/actions/runs/391224455