Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load delta_t after image_data #373

Merged
merged 3 commits into from
May 31, 2021
Merged

Conversation

will-moore
Copy link
Member

@will-moore will-moore commented Mar 15, 2021

Investigating solutions for slow loading of delta_t info.
Fixes #371.

This allows for loading of delta_t info to happen after the initial load of image_data and the update of the UI to show the image.

NB: time.sleep(10) used to simulate slow loading of delta_t, (reported as over 10 secs in issue above).
This slow loading should not cause any issues with the loading of other image data, or update of the UI.

To test (with fake delay temporarily added as above):

  • Open Time-lapse images in iviewer
  • Should see that timestamp info isn't initially loaded (but this doesn't otherwise delay image opening, and being able to interact with the image)
  • Timestamp info should eventually be loaded and displayed after about 10 seconds
  • Switching between images faster than this shouldn't cause any issues (e.g. late loading of delta_t info doesn't get displayed on wrong image.)

If this all works fine, then I'll remove the time.sleep(10) and we can try testing on a real image which has slow loading of timestamp info.

cc @sbesson

NB: temp sleep() used to simulate slow loading
@will-moore will-moore force-pushed the delta_t_loading_delayed branch from 7771501 to 4e3f346 Compare March 15, 2021 14:53
@pwalczysko
Copy link
Member

in my hands, this works fine, as described. Possibly we can step forward with the removal of the time_sleep. If @sbesson could point us to the image, I can import it and test on that.

@pwalczysko
Copy link
Member

Display problem of the timestamp on images with many timepoints. FF, Mac, fairly large screen, tried to expand the central pane in iviewer too, did not help. The timepoints number is printed over by the timestamp, see screenshot.

Screenshot 2021-03-24 at 12 08 06

@pwalczysko
Copy link
Member

  • the timestamp display is fixed
  • the behaviour on the long timelapse is as expected

Ready to merge fmpov

Copy link
Member

@sbesson sbesson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment as #377 (comment)

@sbesson sbesson merged commit 5b9f2df into ome:master May 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

512 timepoints takes long time to load settings
3 participants