Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

active_group switch handles invalid group #273

Merged
merged 2 commits into from
Mar 24, 2021

Conversation

will-moore
Copy link
Member

Fixes #259

To test:

  • Go go /webclient/active_group/ (no ?active_group=1 specified)
  • Should be simply redirected to /webclient (no error as on issue)

@snoopycrimecop
Copy link
Member

snoopycrimecop commented Mar 17, 2021

Conflicting PR. Removed from build OMERO-python-superbuild-push#634. See the console output for more details.
Possible conflicts:

  • PR Update jquery #180 will-moore 'Update jquery'
    • omeroweb/webclient/views.py
  • PR Query string ids #225 will-moore 'Query string ids'
    • omeroweb/webclient/views.py
  • Upstream changes
    • omeroweb/webclient/views.py

--conflicts Conflict resolved in build OMERO-python-superbuild-push#637. See the console output for more details.

@jburel
Copy link
Member

jburel commented Mar 24, 2021

on latest-ci:
https://latest-ci.openmicroscopy.org/web/webclient/active_group/ leads to


  File "/home/omero/workspace/OMERO-web/.venv3/lib64/python3.6/site-packages/omeroweb/webclient/views.py", line 364, in switch_active_group
    active_group = int(active_group)

TypeError: int() argument must be a string, a bytes-like object or a number, not 'NoneType'

<WSGIRequest: GET '/web/webclient/active_group/'>

on merge-ci redirect to https://merge-ci.openmicroscopy.org/web/webclient/

@jburel jburel merged commit 90dd8ad into ome:master Mar 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: int() argument must be a string (from switch_active_group)
3 participants