Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for issue #50 #51

Merged
merged 3 commits into from
Sep 8, 2022
Merged

Fix for issue #50 #51

merged 3 commits into from
Sep 8, 2022

Conversation

khaledk2
Copy link
Collaborator

@khaledk2 khaledk2 commented Sep 5, 2022

This PR addresses issue #50.

It has been deployed on idr-testing.

@will-moore @pwalczysko, please check that and let me know if that is the search behaviour you want.

jburel
jburel reviewed Sep 6, 2022
View reviewed changes
omero_search_engine/api/v1/resources/resource_analyser.py Outdated
@@ -398,6 +395,18 @@ def get_key_values_return_contents(name, resource, csv):
return jsonify(resource_keys)


def adjuest_value(value):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to be renamed to adjust_value

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It has been changed to adjust_value, thank you.

@pwalczysko
Copy link
Member

pwalczysko commented Sep 6, 2022 •
edited
Loading

Thank you @khaledk2

When searching with the contains operator on the page for Gene Symbol with value pax* or pax?, I will get the same results as with http://idr-testing.openmicroscopy.org/search/?key=Gene+Symbol&value=pax&operator=contains . This is probably because the star or question mark are stripped from the pax* or pax? before the search query is sent ?

We should change this so that the pax* or pax? will get only the results which literally match pax*, which are probably 0 images.

Screenshot 2022-09-06 at 10 02 59

@khaledk2
Copy link
Collaborator Author

khaledk2 commented Sep 6, 2022

@pwalczysko It has been fixed and it has been deployed on idr-testing, please check it again and let me know if the issue exists.
http://idr-testing.openmicroscopy.org/search/?key=Gene+Symbol&value=pax*&operator=contains

@pwalczysko
Copy link
Member

@pwalczysko It has been fixed and it has been deployed on idr-testing, please check it again and let me know if the issue exists. http://idr-testing.openmicroscopy.org/search/?key=Gene+Symbol&value=pax*&operator=contains

Thanks. Checked on idr-testing and it works as expected now.

@khaledk2 khaledk2 mentioned this pull request Sep 7, 2022
Merged
@jburel jburel merged commit 3ea889e into ome:main Sep 8, 2022
@khaledk2 khaledk2 mentioned this pull request Mar 23, 2023
Closed
khaledk2 pushed a commit to khaledk2/omero_search_engine that referenced this pull request Jul 11, 2024
@jburel
Merge pull request ome#51 from khaledk2/remove_use_of_wildcards_in_se…
cf9e7fa 
…arch_term

Fix for issue ome#50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jburel jburel jburel left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@khaledk2 @pwalczysko @jburel