Return the exact match first #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ub.com/khaledk2/omero_search_engine into remove_use_of_wildcards_in_search_term
|
#50 has now been merged |
|
Thank you @khaledk2 . LGTM |
pwalczysko
approved these changes
Sep 8, 2022
khaledk2
pushed a commit
to khaledk2/omero_search_engine
that referenced
this pull request
Jul 11, 2024
Return the exact match first
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, the searchengine will try to find the exact match for the query using
/searchvalues/endpoint and will subsequently include possible matches.It is related to the bug on line 20 in the phase 1 test sheet (https://docs.google.com/spreadsheets/d/1yO26q5hAi-Df0s54ZLEiXcc_LO5SOPD8XnDayQx6wjw/edit#gid=1049754075)
It has been deployed on the idr-testing.
This PR is based on PR #51
@will-moore @pwalczysko Please check it and let me know what you think.