-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Schemas publication and version refactoring #2
Conversation
Last commit is consumed in sbesson/ngff@20e74c2 - see https://github.com/sbesson/ngff/runs/6008683630?check_suite_focus=true for the GH Actions, https://github.com/sbesson/ngff/tree/gh-pages for the generated pages and https://sbesson.github.io/ngff/ for the GH pages deployment (esp. https://sbesson.github.io/ngff/0.4/schemas/image.schema) |
Happy to give it a try. We'll still have to work on the |
Something along these lines would be ideal. Two quick comments:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
What's your take-on on the tags management - https://github.com/ome/spec-prod/tags ? are we maintaining a coupling between OME-NGFF spec versions and tags of this action and updated |
Happy to remove the previous versions. Preferably we should post-fix. For what it's worth, upstream is now at v2.7.1! |
👍 for removing the versions as they create confusion with the upstream tags. For the reference, I'd be tempted to use commit SHA1 to be explicit unless you think we should use |
We could try main for a while to reduce the noise. I assume there won't be too many moving parts initially. |
This contains two complementary changes
versions
arrayschemas
lists all existing schemas (currentlyimage.schema
andstrict_image.schema
). Each schema is copied under<version>/schemas
if it exists in the source