Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Schemas publication and version refactoring #2

Merged
merged 2 commits into from
Apr 19, 2022
Merged

Conversation

sbesson
Copy link
Member

@sbesson sbesson commented Apr 13, 2022

This contains two complementary changes

  • 91de3a6 refactors the publication of the BikeShed generated content, removing the need to duplicate actions and using for loops. Ideally, publishing a new version should solely require the addition of an item to the versions array
  • 0c0715a add support for publishing the JSON schemas. A new schemas lists all existing schemas (currently image.schema and strict_image.schema). Each schema is copied under <version>/schemas if it exists in the source

@sbesson sbesson requested a review from joshmoore April 13, 2022 13:56
@sbesson
Copy link
Member Author

sbesson commented Apr 13, 2022

@joshmoore
Copy link
Member

joshmoore commented Apr 13, 2022

Happy to give it a try. We'll still have to work on the glob though 😄

@sbesson
Copy link
Member Author

sbesson commented Apr 13, 2022

We'll still have to work on the glob though 😄

Something along these lines would be ideal. Two quick comments:

  • I think I originally tried to just copy the content <version>/schemas but failed to get the build working after spending a lot of time battling with the action. Possibly someone with more language experience might want to get involved
  • https://github.com/ome/ngff/tree/main/0.3/schemas contains more than the JSON schemas. This PR goes for the conservative approach of only exposing the schemas we would consider for production. Maybe as we start introducing additional schemas, we will want to define rules/clean up old versions and add the logic to discover and publish schemas

Copy link
Member

@joshmoore joshmoore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sbesson
Copy link
Member Author

sbesson commented Apr 19, 2022

What's your take-on on the tags management - https://github.com/ome/spec-prod/tags ? are we maintaining a coupling between OME-NGFF spec versions and tags of this action and updated v4 or is that v5?

@joshmoore
Copy link
Member

Happy to remove the previous versions. Preferably we should post-fix.

For what it's worth, upstream is now at v2.7.1!

@sbesson
Copy link
Member Author

sbesson commented Apr 19, 2022

👍 for removing the versions as they create confusion with the upstream tags. For the reference, I'd be tempted to use commit SHA1 to be explicit unless you think we should use @main?

@joshmoore
Copy link
Member

We could try main for a while to reduce the noise. I assume there won't be too many moving parts initially.

@sbesson sbesson merged commit 38a4de8 into ome:main Apr 19, 2022
@sbesson sbesson deleted the schemas branch April 19, 2022 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants