Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consume main branch of ome/spec-prod action #113

Merged
merged 1 commit into from
May 3, 2022

Conversation

sbesson
Copy link
Member

@sbesson sbesson commented Apr 19, 2022

This should include the latest changes allowing to publish the JSON schemas under ngff.openmicroscopy.org

See ome/spec-prod#2 for more details

This should include the latest changes allowing to publish the JSON
schemas under ngff.openmicroscopy.org
@sbesson sbesson requested a review from joshmoore April 19, 2022 12:38
@joshmoore
Copy link
Member

MSTM, though I assume nothing is being generated for actual review (though that does make me wonder.... 😄)

@sbesson
Copy link
Member Author

sbesson commented Apr 19, 2022

As it stands, I understand the generation will only happen on push to the main branch. For the sake of review, I forced pushed a87990d to the gh-pages branch on my fork and f248283 to the main branch on my fork. sbesson@c4dab4c is the resulting commit generated from this change.

Beyond the scope of this PR and if additional work happens on the action, I imagine this diff could be recorded e.g. as a CI artifact to facilitate the review.

@joshmoore joshmoore added this to the 0.5 milestone Apr 21, 2022
@joshmoore joshmoore merged commit 895d88a into ome:main May 3, 2022
github-actions bot added a commit that referenced this pull request May 3, 2022
Consume main branch of ome/spec-prod action

SHA: 895d88a
Reason: push, by @joshmoore

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@sbesson sbesson deleted the schemas_publication branch May 3, 2022 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants