Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Add NGFF 0.4 JSON Schema validation test #18

Merged
merged 1 commit into from
Apr 30, 2022

Conversation

thewtex
Copy link
Contributor

@thewtex thewtex commented Apr 30, 2022

No description provided.

@thewtex
Copy link
Contributor Author

thewtex commented Apr 30, 2022

Based on the work of @sbesson 🙏

@thewtex thewtex mentioned this pull request Apr 30, 2022
@thewtex thewtex merged commit 79db343 into spatial-image:main Apr 30, 2022
@thewtex thewtex deleted the ngff-validation branch April 30, 2022 21:35
@sbesson
Copy link

sbesson commented May 3, 2022

Thanks for the heads up @thewtex. With ome/ngff#113 now merged, https://ngff.openmicroscopy.org/0.4/schemas/image.schema and other schemas should now start resolving and I assume the downstream packages can start consuming these.

As mentioned in ome/ngff#58, there are a few scalability and usability downsides with dynamically retrieving remote schemas for eac validation. I suspect there will be a use case for distributing these schemas as library resources but we have not yet established the best language-agnostic way to structure this.

1 similar comment
@sbesson
Copy link

sbesson commented May 3, 2022

Thanks for the heads up @thewtex. With ome/ngff#113 now merged, https://ngff.openmicroscopy.org/0.4/schemas/image.schema and other schemas should now start resolving and I assume the downstream packages can start consuming these.

As mentioned in ome/ngff#58, there are a few scalability and usability downsides with dynamically retrieving remote schemas for eac validation. I suspect there will be a use case for distributing these schemas as library resources but we have not yet established the best language-agnostic way to structure this.

@thewtex
Copy link
Contributor Author

thewtex commented May 3, 2022

Thanks for the heads up @thewtex. With ome/ngff#113 now merged, https://ngff.openmicroscopy.org/0.4/schemas/image.schema and other schemas should now start resolving and I assume the downstream packages can start consuming these.

@sbesson wonderful, thank you!

Migrating to this in #27

As mentioned in ome/ngff#58, there are a few scalability and usability downsides with dynamically retrieving remote schemas for eac validation. I suspect there will be a use case for distributing these schemas as library resources but we have not yet established the best language-agnostic way to structure this.

Yes, packages that could be used offilne would be nice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants