refactor: FindMatches to split looong method into multiple private method, use lambda, and relax suppression of checkstyle #1174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miurahr
changed the title
- Make internal methods private - Update javadoc contents - Make tokenize*Stem methods package-private - style: remove final from arguments - revert haveChanceToAdd logic to noChanceToAdd because all conditions are negated Signed-off-by: Hiroshi Miura <miurahr@linux.com>
…inish of thread Signed-off-by: Hiroshi Miura <miurahr@linux.com>
Signed-off-by: Hiroshi Miura <miurahr@linux.com>
miurahr
force-pushed
the
topic/miurahr/search/refactor-find-matches-revert-condition
branch
from
ff3040d to
3b0c5cb
Compare
Signed-off-by: Hiroshi Miura <miurahr@linux.com>
Signed-off-by: Hiroshi Miura <miurahr@linux.com>
This comment was marked as resolved.
This comment was marked as resolved.
Signed-off-by: Hiroshi Miura <miurahr@linux.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FindMatches class has been introduced in 2013 and there are several place to improve coding styles.
Pull request type
Which ticket is resolved?
What does this PR change?
new DefaultTranslationsIterator()andnew MultiTranslationsIterator()to lambda expressionOther information