Add FindMatches class test with segmented #1188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The mock project can process ProjectTMX - implement iterateBy*Translations methods - Ctor accept project TMX file and exernal TMX file. Signed-off-by: Hiroshi Miura <miurahr@linux.com>
- the case FindMatches.search with allowSeparateSegmentMatch Signed-off-by: Hiroshi Miura <miurahr@linux.com>
…nd FindMatches - To test these classes, add ctor which accept Segmenter, FilterMaster as argument - It separates these classes from Core static context Signed-off-by: Hiroshi Miura <miurahr@linux.com>
Signed-off-by: Hiroshi Miura <miurahr@linux.com>
- It interference with FindMatchesTest Signed-off-by: Hiroshi Miura <miurahr@linux.com>
miurahr
deleted the
topic/miurahr/statistics/refactor-findmatches-segmented
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FindMatchesclass ctor has a argument of booleanallowSeparateSegmentMatch.This PR add a test case with the option and test the chunk of the feature.
Pull request type
Improve test coverage, Quality Assurance
What does this PR change?
defaultsandalternativesfields asprotectedfor mockingTestProjectinternal classtestSegmentedcalcMatchStatisticsTestto handleSegmenterandTestProjectSegmenterTestFindMatches,CalcMatchStatistics,ExternalTMFactory, andProjectTMX.Other information