Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAG2: Code maintenance. Renaming class 'PaymentCcTokenBuilder' to 'CreditCardBuilder'. #131

Merged
merged 1 commit into from
Jul 3, 2018

Conversation

guzzilar
Copy link
Contributor

@guzzilar guzzilar commented Jul 2, 2018

1. Objective

Regarding to the coming 'save-card' feature.
There will be a condition where the card's value will be assigned either as a 'token' or as a 'card_id' depending on what buyer choose from the front-end.
Meaning that, 'PaymentCcTokenBuilder' name will not reflect with the above condition

So here, I think to rename this class to make it conform with its functionality is important one.

Note. Originally, this class has been designed to only serve for 'card = token_id' purpose (we didn't design this class to support save card feature) therefore we need to update it.

2. Description of change

  • Simply renaming class name.

3. Quality assurance

🔧 Environments:

  • Platform version: Magento CE 2.2.3
  • PHP version: 7.1.16.

✏️ Details:

  • Make sure that we can still create a charge using credit card payment method.
    Tested. It works.

4. Impact of the change

  • If you have already installed Omise-Magento, you are going to need to at least, flush the store cache (there is a change in an xml file in this PR).
  • If there is any problem during the check out after flushing your store's cache. Try run composer dump-autoload from the root folder of your Magento directory.

5. Priority of change

Normal

6. Additional Notes

Regarding to the coming 'save-card' feature.
There will be a condition where the card's value will be assigned either as a 'token' or as a 'card_id' depending on what buyer choose from the front-end.
Meaning that, 'PaymentCcTokenBuilder' name will not reflect with the above condition

So here, I think to rename this class to make it conform with its functionality is important one.

Note. Originally, this class has been designed to only serve for 'card = token_id' purpose (we didn't design this class to support save card feature) therefore we need to update it.
Copy link
Contributor

@jacstn jacstn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool... thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants