MAG2: Code maintenance. Renaming class 'PaymentCcTokenBuilder' to 'CreditCardBuilder'. #131
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Objective
Regarding to the coming 'save-card' feature.
There will be a condition where the card's value will be assigned either as a 'token' or as a 'card_id' depending on what buyer choose from the front-end.
Meaning that, 'PaymentCcTokenBuilder' name will not reflect with the above condition
So here, I think to rename this class to make it conform with its functionality is important one.
Note. Originally, this class has been designed to only serve for 'card = token_id' purpose (we didn't design this class to support save card feature) therefore we need to update it.
2. Description of change
3. Quality assurance
🔧 Environments:
✏️ Details:
credit card
payment method.Tested. It works.
4. Impact of the change
flush
the store cache (there is a change in an xml file in this PR).composer dump-autoload
from the root folder of your Magento directory.5. Priority of change
Normal
6. Additional Notes