-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Google fonts other than Poppins #416
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muthuswamyopn
previously approved these changes
Nov 13, 2023
AnasNaouchi
previously approved these changes
Nov 13, 2023
danfowler
reviewed
Nov 13, 2023
aashishgurung
dismissed stale reviews from AnasNaouchi and muthuswamyopn
via
November 13, 2023 03:37
38eafbf
danfowler
reviewed
Nov 13, 2023
tests/unit/includes/gateway/class-omise-payment-internetbanking-test.php
Show resolved
Hide resolved
danfowler
reviewed
Nov 13, 2023
danfowler
reviewed
Nov 13, 2023
annatotest
reviewed
Nov 13, 2023
danfowler
reviewed
Nov 13, 2023
danfowler
reviewed
Nov 13, 2023
danfowler
previously approved these changes
Nov 13, 2023
danfowler
reviewed
Nov 13, 2023
…into support_custom_fonts
annatotest
previously approved these changes
Nov 14, 2023
danfowler
previously approved these changes
Nov 14, 2023
danfowler
reviewed
Nov 14, 2023
aashishgurung
dismissed stale reviews from danfowler and annatotest
via
November 14, 2023 07:54
c8ffd66
danfowler
previously approved these changes
Nov 14, 2023
annatotest
approved these changes
Nov 14, 2023
AnasNaouchi
approved these changes
Nov 14, 2023
This was referenced Nov 15, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Objective
Support Google fonts other than Poppins
2. Description of change
Add
others
as an option to font name. This will activate a field where you can specify the Google font that you want to use🔧 Environments: