Fixed a custom font name bug #419
Merged
+52
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 16, 2023 15:11
…ecure form settings.
…into bug/custom_font
aashishgurung
requested review from
danfowler,
AnasNaouchi,
annatotest and
a team
AnasNaouchi
approved these changes
Nov 16, 2023
danfowler
approved these changes
Nov 16, 2023
annatotest
approved these changes
Nov 16, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Objective
Fixed a bug for previous merchants without
custom namefield in the secure form settings.Related information:
Related issue(s): #416
2. Description of change
Added a logic to add
custom_namefor the merchants who has been using secure form since they won't have it instantly after upgrading the plugin.3. Quality assurance
Specify where and how you tested this and what further testing it might need.
🔧 Environments:
WooCommerce: v8.2.2
WordPress: v6.4.1-alpha-57080
PHP version: 8.1