Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add AlphaWallet as a supporting wallet for xDAI #186

Merged
merged 2 commits into from
Feb 25, 2019
Merged

add AlphaWallet as a supporting wallet for xDAI #186

merged 2 commits into from
Feb 25, 2019

Conversation

bitcoinwarrior1
Copy link

@bitcoinwarrior1 bitcoinwarrior1 commented Feb 21, 2019

For #185

@netlify
Copy link

netlify bot commented Feb 21, 2019

Deploy preview for kind-kilby-95344f processing.

Building with commit 8d1be1b

https://app.netlify.com/sites/kind-kilby-95344f/deploys/5c73e5ac2fff59000834816c

@coveralls
Copy link

coveralls commented Feb 21, 2019

Pull Request Test Coverage Report for Build 340

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 3.232%

Totals Coverage Status
Change from base Build 339: 0.0%
Covered Lines: 46
Relevant Lines: 1090

💛 - Coveralls

Copy link
Collaborator

@akolotov akolotov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for work!
Consider to have one link to your side instead of two links on the markets.

Copy link

@patitonar patitonar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!
Could you also commit the compiled css file src/assets/stylesheets/application.css after running npm run build-css? Otherwise style changes won't be applied.

@bitcoinwarrior1
Copy link
Author

@patitonar fixed, @akolotov where do you mean? For download links we should have both since then you have support for desktop, iOS and android :)

@patitonar
Copy link

I think what @akolotov means is that instead of having two buttons for AlphaWallet (one for iOS and one for Android) we should have only one that links to https://alphawallet.com/. If we do that, I think we should update the description (please install one (AlphaWallet, Metamask or Nifty Wallet)) to be more clear that Metamask and Nifty Wallet should be installed for browser and AlphaWallet for iOS and Android. What do you think @James-Sangalli ?

@bitcoinwarrior1
Copy link
Author

@patitonar ok but for the page which says you have no wallet, would you agree that putting the direct download links for an iOS, android and desktop client is best? Would rather the user could get the download promptly rather than searching the website first.

Agree it would be a good idea to mention in the readme which is desktop and which is mobile :)

@patitonar
Copy link

@James-Sangalli The current links on Metamask and Nifty wallet buttons doesn't link to their download site, but to a site with instructions on how to download (on different browsers as Chrome and Firefox) and getting started with the wallet. (Actually I just notice that links are broken, but they should be something like https://forum.poa.network/t/nifty-wallet-guide/1789 and https://forum.poa.network/t/wallet-metamask-extension/1819)

I think we should continue with this behavior and so have only one button for AlphaWallet that links to the website or an specific page with instructions for the user to download the app on their platform.

That this makes sense?

@akolotov
Copy link
Collaborator

@James-Sangalli I agree with @patitonar in order to keep better user experience and consistency

  1. We provide one link per wallet regardless of the platform.
  2. The link to the instructions how to install and configure the wallet is more preferable since it allows to present how exactly it will address the user's needs.

@bitcoinwarrior1
Copy link
Author

Ok @akolotov & @patitonar as you wish, I have changed the commit to only use one link which will send the user to a page providing some info and links to download or go to the website. Please merge when you can.

Copy link

@patitonar patitonar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the work @James-Sangalli ! Looks good to me. There is a merge conflict that need to be resolved before we can merge this. Sorry about this, but now that #187 is merged, application.css shouldn't be versioned anymore.

Copy link
Collaborator

@akolotov akolotov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! We will merge the PR as soon as the merge conflict is addressed.

@bitcoinwarrior1
Copy link
Author

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants