-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add AlphaWallet as a supporting wallet for xDAI #186
Conversation
Deploy preview for kind-kilby-95344f processing. Building with commit 8d1be1b https://app.netlify.com/sites/kind-kilby-95344f/deploys/5c73e5ac2fff59000834816c |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for work!
Consider to have one link to your side instead of two links on the markets.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
Could you also commit the compiled css file src/assets/stylesheets/application.css
after running npm run build-css
? Otherwise style changes won't be applied.
@patitonar fixed, @akolotov where do you mean? For download links we should have both since then you have support for desktop, iOS and android :) |
I think what @akolotov means is that instead of having two buttons for AlphaWallet (one for iOS and one for Android) we should have only one that links to https://alphawallet.com/. If we do that, I think we should update the description ( |
@patitonar ok but for the page which says you have no wallet, would you agree that putting the direct download links for an iOS, android and desktop client is best? Would rather the user could get the download promptly rather than searching the website first. Agree it would be a good idea to mention in the readme which is desktop and which is mobile :) |
@James-Sangalli The current links on Metamask and Nifty wallet buttons doesn't link to their download site, but to a site with instructions on how to download (on different browsers as Chrome and Firefox) and getting started with the wallet. (Actually I just notice that links are broken, but they should be something like https://forum.poa.network/t/nifty-wallet-guide/1789 and https://forum.poa.network/t/wallet-metamask-extension/1819) I think we should continue with this behavior and so have only one button for That this makes sense? |
@James-Sangalli I agree with @patitonar in order to keep better user experience and consistency
|
Ok @akolotov & @patitonar as you wish, I have changed the commit to only use one link which will send the user to a page providing some info and links to download or go to the website. Please merge when you can. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the work @James-Sangalli ! Looks good to me. There is a merge conflict that need to be resolved before we can merge this. Sorry about this, but now that #187 is merged, application.css
shouldn't be versioned anymore.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! We will merge the PR as soon as the merge conflict is addressed.
Done. |
For #185