Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emoji modifiers don't seem to work. #59

Closed
hex2f opened this issue Oct 6, 2017 · 3 comments
Closed

Emoji modifiers don't seem to work. #59

hex2f opened this issue Oct 6, 2017 · 3 comments
Labels
status: accepting prs Please, send a pull request to resolve this! type: feature New enhancement or request

Comments

@hex2f
Copy link

hex2f commented Oct 6, 2017

Problem

I want to unemojify emojis that have modifiers (gender, color) but for some reason it doesn't even detect these as emojis.

Example

require('node-emoji').hasEmoji('🤦‍♂') => false
require('node-emoji').find('🤦‍♂') => undefined

Expected

require('node-emoji').hasEmoji('🤦‍♂') => true
require('node-emoji').find('🤦‍♂') => ":man_facepalming:"

@omnidan
Copy link
Owner

omnidan commented Oct 23, 2017

this is not implemented right now, also see #57. Unfortunately I don't have much time myself right now, but PRs are welcome 😁

@omnidan omnidan added type: feature New enhancement or request status: accepting prs Please, send a pull request to resolve this! labels Oct 23, 2017
@timkinnane
Copy link

Hey @omnidan - this is a cool lib and I'd like to contribute. Would you mind updating the readme to separate the implemented features from those still on the roadmap as a starting point.

I only checked the issues after some time debugging my usage to find why they were returning undefined.

@JoshuaKGoldberg
Copy link
Collaborator

I just tried this out with node-emoji@v2.0.2 and it works! 🙌

import * as emoji from "node-emoji";

console.log(emoji.has("🤦‍♂"));
console.log(emoji.find("🤦‍♂"));

Must have been resolved by #113 switching to emojilib for emojis. Yay!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: accepting prs Please, send a pull request to resolve this! type: feature New enhancement or request
Projects
None yet
Development

No branches or pull requests

4 participants