Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support skin color modifiers #57

Closed
highfeed opened this issue Oct 3, 2017 · 3 comments · Fixed by #86 or #113
Closed

support skin color modifiers #57

highfeed opened this issue Oct 3, 2017 · 3 comments · Fixed by #86 or #113
Labels
status: accepting prs Please, send a pull request to resolve this! type: feature New enhancement or request

Comments

@highfeed
Copy link

highfeed commented Oct 3, 2017 •
edited by omnidan
Loading

Hello!

Why don't work this emoji?

https://runkit.com/embed/3gxoc1t1b4pn
@hex2f
Copy link

hex2f commented Oct 6, 2017

+1

1 similar comment
@Extracreative
Copy link

+1

@omnidan
Copy link
Owner

omnidan commented Oct 23, 2017

@highfeed these emoji are actually two characters: the original emoji + a skin color modifier. Skin color modifiers are not implemented in this library yet. Unfortunately I don't have much time myself right now, but PRs are welcome 😁

@omnidan omnidan added type: feature New enhancement or request status: accepting prs Please, send a pull request to resolve this! labels Oct 23, 2017
@omnidan omnidan changed the title Why don't work this emoji? support skin color modifiers Oct 23, 2017
@omnidan omnidan mentioned this issue Oct 23, 2017
Closed
@cinnamon-bun cinnamon-bun mentioned this issue Jun 13, 2019
Merged
Richienb added a commit that referenced this issue Mar 10, 2020
@Richienb
refactor: Support skin tones Fixes #62 Fixes #57
6514abd 
Signed-off-by: Richie Bendall <richiebendall@gmail.com>
@Richienb Richienb mentioned this issue Mar 14, 2020
Merged
@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Nov 18, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: accepting prs Please, send a pull request to resolve this! type: feature New enhancement or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

v2 Refactor omnidan/node-emoji
v2 Refactor, Refactored JoshuaKGoldberg/node-emoji
4 participants
@omnidan @Extracreative @highfeed @hex2f