-
-
Notifications
You must be signed in to change notification settings - Fork 241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v2 Refactor, Refactored #113
v2 Refactor, Refactored #113
Conversation
Signed-off-by: Richie Bendall <richiebendall@gmail.com>
Signed-off-by: Richie Bendall <richiebendall@gmail.com>
Signed-off-by: Richie Bendall <richiebendall@gmail.com>
Signed-off-by: Richie Bendall <richiebendall@gmail.com>
Signed-off-by: Richie Bendall <richiebendall@gmail.com>
Signed-off-by: Richie Bendall <richiebendall@gmail.com>
Signed-off-by: Richie Bendall <richiebendall@gmail.com>
Signed-off-by: Richie Bendall <richiebendall@gmail.com>
…cores Signed-off-by: Richie Bendall <richiebendall@gmail.com>
… native methods. Signed-off-by: Richie Bendall <richiebendall@gmail.com>
… and add findAll (Fixes omnidan#74) Signed-off-by: Richie Bendall <richiebendall@gmail.com>
Signed-off-by: Richie Bendall <richiebendall@gmail.com>
Signed-off-by: Richie Bendall <richiebendall@gmail.com>
Co-Authored-By: Jameson <jamesonjlee@users.noreply.github.com>
Signed-off-by: Richie Bendall <richiebendall@gmail.com>
Signed-off-by: Richie Bendall <richiebendall@gmail.com>
Signed-off-by: Richie Bendall <richiebendall@gmail.com>
Signed-off-by: Richie Bendall <richiebendall@gmail.com>
Signed-off-by: Richie Bendall <richiebendall@gmail.com>
Signed-off-by: Richie Bendall <richiebendall@gmail.com>
Signed-off-by: Richie Bendall <richiebendall@gmail.com>
Signed-off-by: Richie Bendall <richiebendall@gmail.com>
Signed-off-by: Richie Bendall <richiebendall@gmail.com>
Signed-off-by: Richie Bendall <richiebendall@gmail.com>
Ping @omnidan, are you still interested in this work being completed? |
@JoshuaKGoldberg yes that would be great! I'm always on our discord so feel free to ping me there for discussions 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me now! Thanks for updating the PR and finishing it up @JoshuaKGoldberg!
Don't know if we've discussed this before in the repo, but we could use |
But otherwise, this is pretty nice |
#86 but with the changes suggested by maintainers and/or proposed by me as comments. Most notably:
standard
and much of the excess.git*
metadatareplace
fromremoveSpaces = true
topreserveSpaces = false
These are the breaking changes I can spot compared to v1 (please comment if there are others!):
emojilib
instead of in-house emojis, causing slight differences in emoji namesemojify
takes infallback
and/orformat
as members of an object parameter instead of in serieshasEmoji
is now calledhas
to match with other single-word API namesreplace
takes inpreserveSpaces
as an optional member of an optional object parameter instead of as its own parameterIntentionally leaves the following major changes out to be discussed separately:
.prettierrc.json
to help editor Prettier extensions match the existing settings)Closes #55, Closes #57, Closes #62, Closes #66, Closes #77.
Intentionally based on #86's
v2
branch to preserve @Richienb as an author in history.