Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2 Refactor, Refactored #113

Merged
merged 48 commits into from
May 15, 2023
Merged

Conversation

JoshuaKGoldberg
Copy link
Collaborator

@JoshuaKGoldberg JoshuaKGoldberg commented Nov 18, 2021

#86 but with the changes suggested by maintainers and/or proposed by me as comments. Most notably:

  • Revamped README.md, including linking to new dependencies
  • Removes standard and much of the excess .git* metadata
  • Uses Jest as the test runner instead of Ava
  • Switches replace from removeSpaces = true to preserveSpaces = false

These are the breaking changes I can spot compared to v1 (please comment if there are others!):

  • Uses emojilib instead of in-house emojis, causing slight differences in emoji names
  • emojify takes in fallback and/or format as members of an object parameter instead of in series
  • hasEmoji is now called has to match with other single-word API names
  • replace takes in preserveSpaces as an optional member of an optional object parameter instead of as its own parameter

Intentionally leaves the following major changes out to be discussed separately:

  • ESM modules
  • Prettier (though I did add a .prettierrc.json to help editor Prettier extensions match the existing settings)
  • TypeScript

Closes #55, Closes #57, Closes #62, Closes #66, Closes #77.

Intentionally based on #86's v2 branch to preserve @Richienb as an author in history.

Richienb and others added 30 commits January 7, 2020 23:15
Signed-off-by: Richie Bendall <richiebendall@gmail.com>
Signed-off-by: Richie Bendall <richiebendall@gmail.com>
Signed-off-by: Richie Bendall <richiebendall@gmail.com>
Signed-off-by: Richie Bendall <richiebendall@gmail.com>
Signed-off-by: Richie Bendall <richiebendall@gmail.com>
Signed-off-by: Richie Bendall <richiebendall@gmail.com>
Signed-off-by: Richie Bendall <richiebendall@gmail.com>
Signed-off-by: Richie Bendall <richiebendall@gmail.com>
…cores

Signed-off-by: Richie Bendall <richiebendall@gmail.com>
… native methods.

Signed-off-by: Richie Bendall <richiebendall@gmail.com>
… and add findAll (Fixes omnidan#74)

Signed-off-by: Richie Bendall <richiebendall@gmail.com>
Signed-off-by: Richie Bendall <richiebendall@gmail.com>
Signed-off-by: Richie Bendall <richiebendall@gmail.com>
Co-Authored-By: Jameson <jamesonjlee@users.noreply.github.com>
Signed-off-by: Richie Bendall <richiebendall@gmail.com>
Signed-off-by: Richie Bendall <richiebendall@gmail.com>
Signed-off-by: Richie Bendall <richiebendall@gmail.com>
Signed-off-by: Richie Bendall <richiebendall@gmail.com>
Signed-off-by: Richie Bendall <richiebendall@gmail.com>
Signed-off-by: Richie Bendall <richiebendall@gmail.com>
Signed-off-by: Richie Bendall <richiebendall@gmail.com>
Signed-off-by: Richie Bendall <richiebendall@gmail.com>
Signed-off-by: Richie Bendall <richiebendall@gmail.com>
Signed-off-by: Richie Bendall <richiebendall@gmail.com>
@JoshuaKGoldberg JoshuaKGoldberg marked this pull request as ready for review November 26, 2021 08:25
@JoshuaKGoldberg JoshuaKGoldberg mentioned this pull request Nov 26, 2021
@JoshuaKGoldberg
Copy link
Collaborator Author

Ping @omnidan, are you still interested in this work being completed?

@omnidan
Copy link
Owner

omnidan commented Apr 16, 2022

@JoshuaKGoldberg yes that would be great! I'm always on our discord so feel free to ping me there for discussions 😄

README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
Copy link
Owner

@omnidan omnidan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me now! Thanks for updating the PR and finishing it up @JoshuaKGoldberg!

@Richienb
Copy link
Collaborator

Don't know if we've discussed this before in the repo, but we could use Intl.Segmenter which is marginally better than char-regex but requires Node.js >16.

@Richienb
Copy link
Collaborator

But otherwise, this is pretty nice

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

support skin color modifiers re-work README
4 participants