Possibility to strip the keys from string #101
Conversation
|
👋 @iwollmannl, new junior maintainer here picking up old threads - do you still want this? 😄 As of #113, functions such as I also question whether this is something |
JoshuaKGoldberg
added
the
status: waiting for author
| /** | ||
| * regex to remove emoji key strings, e.g. "":coffee: coffee" -> coffee | ||
| */ | ||
| var removeNameRegex = /:.*?\:/; |
There was a problem hiding this comment.
[Style] The ? is unnecessary. .*? says:
.: any character*: any number of times (including 0)?: optionally
I'm betting the regular expression shouldn't match ::. So it can be simplified to:
| var removeNameRegex = /:.*?\:/; | |
| var removeNameRegex = /:.+:/; |
| it('Should be able to strip all emojis names', function() { | ||
| var result = emoji.strip('I :heart: cleaning and :coffee:', true); | ||
| result.should.equal('I cleaning and '); | ||
| }); |
There was a problem hiding this comment.
[Testing] Thinking about the test cases, there are some that should probably be added:
- A string with
::somewhere in it - Colons that shouldn't be matched, like
I: the great lover of coffeeandI: coffee. You: tea. - A string that has emojis and
:name:s
|
@iwollmann if you're still interested in this, could you provide an example where such a functionality would be useful? trying to figure out if it should be a generally supported function or not. like you said, it's easy to do it with a regex replace. |
|
Closing out since it's been a few months without response. Cheers! |
|
Hey @JoshuaKGoldberg I'm really sorry, this was hitting my spam box and I wasn't following it here anymore. To be honest I do not remember the actual case for this, but if you want I can update the PR with the requested changes. |
|
Ha, GitHub hitting spam - been there! No worries - I think the PR is more blocked on an explanation of why this would be useful to have in the library. #101 (comment) |
|
Nop, I remember that was something related with a markdown version and I had this need to strip the emoji format from the md text but can't remember in more details =/ |
I have this need recently and realized that the strip function doesn't attended my needs, so I needed to make a regex to treat that on my project and I would love it so see that incorporated on this project.
Please, take a look and see if it's makes sense to have this here.
Basically it's remove a string that contains the emojis keys, e.g. I :love: cleaning -> I cleanning