Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add container to job-properties schema #403

Merged

Conversation

fschuch
Copy link
Member

@fschuch fschuch commented Nov 2, 2023

What

Add container to job-properties schema

Why

It is new in Slurm RESTD 0.0.38


Peer Review

Please follow the upstream omnivector documentation concerning
peer-review guidelines.

It is new in Slurm RESTD 0.0.38
It looks like latest version is breaking QA tests on the API
@fschuch fschuch merged commit 2c51a2f into main Nov 2, 2023
@fschuch fschuch deleted the fschuch/quickfix--add-container-to-job-properties-mapper branch November 2, 2023 12:06
@omnivector-qa
Copy link
Contributor

The backport to release/4.0 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-release/4.0 release/4.0
# Navigate to the new working tree
cd .worktrees/backport-release/4.0
# Create a new branch
git switch --create backport-403-to-release/4.0
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 2c51a2ffacdb22499e609147171b2c827d763020
# Push it to GitHub
git push --set-upstream origin backport-403-to-release/4.0
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-release/4.0

Then, create a pull request where the base branch is release/4.0 and the compare/head branch is backport-403-to-release/4.0.

@fschuch fschuch restored the fschuch/quickfix--add-container-to-job-properties-mapper branch November 2, 2023 12:09
@omnivector-qa
Copy link
Contributor

The backport to release/4.0 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-release/4.0 release/4.0
# Navigate to the new working tree
cd .worktrees/backport-release/4.0
# Create a new branch
git switch --create backport-403-to-release/4.0
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 2c51a2ffacdb22499e609147171b2c827d763020
# Push it to GitHub
git push --set-upstream origin backport-403-to-release/4.0
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-release/4.0

Then, create a pull request where the base branch is release/4.0 and the compare/head branch is backport-403-to-release/4.0.

fschuch added a commit that referenced this pull request Nov 2, 2023
* fix(api): add container to job-properties schema

It is new in Slurm RESTD 0.0.38

* fix: pin minio version on jobbergate-composed

It looks like latest version is breaking QA tests on the API

(cherry picked from commit 2c51a2f)
fschuch added a commit that referenced this pull request Nov 2, 2023
* fix(api): add container to job-properties schema

It is new in Slurm RESTD 0.0.38

* fix: pin minio version on jobbergate-composed

It looks like latest version is breaking QA tests on the API

(cherry picked from commit 2c51a2f)
@fschuch fschuch deleted the fschuch/quickfix--add-container-to-job-properties-mapper branch November 7, 2023 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants