Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add container to job-properties schema #403

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion jobbergate-api/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ This file keeps track of all notable changes to jobbergate-api
- Changed internals to avoid committing to the database when a GET request is made
- Added extra settings to allow profiling and tracing on sentry
- Removed db-start from dev-tools

- Added `container` on job properties for submissions, new in Slurm REST 0.0.38

## 4.1.0a2 -- 2023-10-10
- Made `runtime_config` optional when uploading a workflow file
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ class SbatchToSlurm:
SbatchToSlurm("", "--clusters", "-M"),
SbatchToSlurm("comment", "--comment"),
SbatchToSlurm("constraints", "--constraint", "-C"),
SbatchToSlurm("", "--container"),
SbatchToSlurm("container", "--container"),
SbatchToSlurm("", "--contiguous", "", dict(action="store_const", const=True)),
SbatchToSlurm("core_specification", "--core-spec", "-S", dict(type=int)),
SbatchToSlurm("cores_per_socket", "--cores-per-socket", "", dict(type=int)),
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,7 @@ class JobProperties(BaseModel, extra=Extra.forbid):
)
comment: Optional[str] = Field(description="An arbitrary comment.")
constraints: Optional[str] = Field(description="node features required by job.")
container: Optional[str] = Field(description="Absolute path to OCI container bundle.")
core_specification: Optional[int] = Field(
description=(
"Count of specialized threads per node reserved by the job for system "
Expand Down
2 changes: 1 addition & 1 deletion jobbergate-composed/docker-compose.yml
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,7 @@ services:
retries: 5

minio:
image: minio/minio
image: minio/minio:RELEASE.2023-10-25T06-33-25Z
fschuch marked this conversation as resolved.
Show resolved Hide resolved
networks:
- jobbergate-net
volumes:
Expand Down