Add prefixes to macros #571
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit update the macros used internally adding the prefix ONEAPI_ONEMKL_. This change creates a mismatch between the cmake variables used for configuration and the internal macros. Cmake configuration stays the same while, macros are now conformant with C++ guidelines. Signed-off-by: nscipione <nicolo.scipione@codeplay.com>
Rbiessy
reviewed
Sep 17, 2024
Moved variables setting for headers to a more appropriate section of the configuration.
Rbiessy
reviewed
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds
ONEAPI_ONEMKL_prefix to all the variables defined inconfig.hpp.into be conformant with ES.33 C++ Core Guidelines.Fixes # (GitHub issue)
This change was requested in #554
Checklist
All Submissions
Do all unit tests pass locally? Attach a log.
portblas_log.txt
portfft_log.txt
nvidia_all_domains_log.txt
cpu_mkl_all_domains_log.txt
arc_mklgpu_all_domains_log.txt
Have you formatted the code using clang-format?