Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add prefixes to macros #571

Merged
merged 10 commits into from
Oct 15, 2024
Merged

Add prefixes to macros #571

merged 10 commits into from
Oct 15, 2024
+206 −181

Commits on Oct 10, 2024

  1. Rename macros used in headers 

    This commit update the macros used internally adding the prefix
ONEAPI_ONEMKL_. This change creates a mismatch between the cmake
variables used for configuration and the internal macros. Cmake
configuration stays the same while, macros are now conformant with C++
guidelines.

Signed-off-by: nscipione <nicolo.scipione@codeplay.com>
    @s-Nick
    s-Nick committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    89a139f View commit details
    Browse the repository at this point in the history

  2. Add comment to justify cmake changes and reason

    @s-Nick
    s-Nick committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    d4d2364 View commit details
    Browse the repository at this point in the history

  3. Revert some changes only in CMake files and documentation

    @s-Nick
    s-Nick committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    6edba7d View commit details
    Browse the repository at this point in the history

  4. Revert changes in cmake

    @s-Nick
    s-Nick committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    8942c77 View commit details
    Browse the repository at this point in the history

  5. Address PR comment to reduce noise in this PR

    @s-Nick
    s-Nick committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    e079170 View commit details
    Browse the repository at this point in the history

  6. Move cmake instruction to keep configuration clean 

    Moved variables setting for headers to a more appropriate section of
the configuration.
    @s-Nick
    s-Nick committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    7eaa348 View commit details
    Browse the repository at this point in the history

  7. Add function to generate header file to reduce specific variable scope

    @s-Nick
    s-Nick committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    ce6feaa View commit details
    Browse the repository at this point in the history

  8. Address PR feedback

    @s-Nick
    s-Nick committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    0f8fb22 View commit details
    Browse the repository at this point in the history

  9. Update cmake define for blas test

    @s-Nick
    s-Nick committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    7c79ac8 View commit details
    Browse the repository at this point in the history

  10. Update macro to a smaller one following PR conversation 

    Reducing macro name from "ONEAPI_ONEMKL" to "ONEMKL"
    @s-Nick
    s-Nick committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    2a739a8 View commit details
    Browse the repository at this point in the history