[draft] Add new experimental entry point for get native mem on device#1199
[draft] Add new experimental entry point for get native mem on device#1199hdelan wants to merge 1 commit intooneapi-src:mainfrom
Conversation
358e0bc to
85ae4b0
Compare
85ae4b0 to
e4682d9
Compare
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #1199 +/- ##
==========================================
+ Coverage 15.74% 15.82% +0.08%
==========================================
Files 223 223
Lines 31466 31591 +125
Branches 3556 3578 +22
==========================================
+ Hits 4953 5000 +47
- Misses 26462 26540 +78
Partials 51 51 ☔ View full report in Codecov by Sentry. |
| - type: $x_device_handle_t | ||
| name: hDevice | ||
| desc: | | ||
| [in] handle of the device that native handle will be resident on. |
There was a problem hiding this comment.
I think we should just modify the existing GetNativeHandle to add this argument.
There was a problem hiding this comment.
Is that not an ABI breaking change that will take some time to get merged?
There was a problem hiding this comment.
We don't claim ABI stability in UR at this time, this won't be an issue as long as the necessary SYCL RT changes are made in tandem with this.
There was a problem hiding this comment.
Great thanks @kbenzie . I will close this PR and open a new one with just changes to the existing entry point
|
Hi @kbenzie this entry point is needed for both accessor interop as well as buffer interop. So do you think it's OK to have the same entry point for both (as is currently the case)? For accessor interop we can call Do you think that is acceptable or should we split this into two entry points, as this PR does? |
|
I'm not really sure what the implications are here, would need to have a bit more info about why the buffer interop path differs I think. |
#12297) We want to change the signature of `piMemGetNativeHandle` for reasons explained here oneapi-src/unified-runtime#1199 Corresponding UR PR: oneapi-src/unified-runtime#1226 A previous PR added a new entry point #12199 but it was decided that it is better to modify the existing entry point
Accessor interop requires
urMemGetNativeHandleto return a valid mem handle. Multi dev ctx breaks this because a UR mem can be on many different devices now, so we need a new entry point that also takes a device or a queue param.Will wait until @kbenzie is back to discuss the best approach