[UR] Add extra param to urMemGetNativeHandle by hdelan · Pull Request #1226 · oneapi-src/unified-runtime

hdelan · 2024-01-04T10:01:52Z

Add an extra param to urMemGetNativeHandle as suggested here #1199 (comment)

codecov-commenter · 2024-01-04T10:15:58Z

Codecov Report

Attention: 21 lines in your changes are missing coverage. Please review.

Comparison is base (40517d2) 15.44% compared to head (fc1f306) 15.44%.

Files	Patch %	Lines
test/conformance/memory/urMemGetNativeHandle.cpp	0.00%	6 Missing ⚠️
include/ur_print.hpp	0.00%	4 Missing ⚠️
source/loader/layers/validation/ur_valddi.cpp	0.00%	3 Missing ⚠️
source/loader/layers/tracing/ur_trcddi.cpp	0.00%	2 Missing ⚠️
source/loader/ur_ldrddi.cpp	0.00%	2 Missing ⚠️
source/adapters/null/ur_nullddi.cpp	0.00%	1 Missing ⚠️
source/loader/ur_libapi.cpp	0.00%	1 Missing ⚠️
...mance/memory/urMemBufferCreateWithNativeHandle.cpp	0.00%	1 Missing ⚠️
...rmance/memory/urMemImageCreateWithNativeHandle.cpp	0.00%	1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1226      +/-   ##
==========================================
- Coverage   15.44%   15.44%   -0.01%     
==========================================
  Files         239      239              
  Lines       33961    33970       +9     
  Branches     3757     3758       +1     
==========================================
  Hits         5246     5246              
- Misses      28664    28673       +9     
  Partials       51       51

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

hdelan · 2024-01-12T10:46:49Z

Gentle ping @GeorgeWeb @oneapi-src/unified-runtime-native-cpu-write @oneapi-src/unified-runtime-level-zero-write @oneapi-src/unified-runtime-opencl-write

Would be great to get some reviews

muhammad-tanvir-1211 · 2024-01-12T11:20:48Z

This PR is blocking the following two PRs on oneMKL as all the buffer tests (with accessor interop) are failing for the rocblas backend with PI_ERROR_INVALID_OPERATION.
uxlfoundation/oneMath#428
uxlfoundation/oneMath#425

Logs:
PR_425.txt
PR_428.txt

GeorgeWeb

HIP and CUDA adapters changes look good to me.

See my inline comment regarding the new return code in the hip-nvidia path of the entry point, which is not a blocker, but I'd like to see your view on it.

source/adapters/hip/memory.cpp

ldrumm

Your commit messages lack any info into what parameter is added and why. Please include context so future you can actually understand motivation

scripts/core/memory.yml

scripts/core/HIP.rst

scripts/core/CUDA.rst

source/adapters/hip/memory.cpp

scripts/core/CUDA.rst

PietroGhg

Native CPU lgtm

hdelan · 2024-01-12T12:04:21Z

Your commit messages lack any info into what parameter is added and why. Please include context so future you can actually understand motivation

@ldrumm Have changed the commit message

ldrumm · 2024-01-12T12:23:52Z

Your commit messages lack any info into what parameter is added and why. Please include context so future you can actually understand motivation

Not any more!

Thanks and LGTM

hdelan · 2024-01-22T22:05:14Z

Friendly ping @oneapi-src/unified-runtime-level-zero-write

nrspruit

LGTM for level-zero

#12297) We want to change the signature of `piMemGetNativeHandle` for reasons explained here oneapi-src/unified-runtime#1199 Corresponding UR PR: oneapi-src/unified-runtime#1226 A previous PR added a new entry point #12199 but it was decided that it is better to modify the existing entry point

hdelan requested review from a team as code owners January 4, 2024 10:01

hdelan requested a review from GeorgeWeb January 4, 2024 10:01

hdelan marked this pull request as draft January 4, 2024 10:01

hdelan force-pushed the get-native-mem-on-device2 branch 5 times, most recently from 453025b to 2910cd4 Compare January 4, 2024 15:11

hdelan marked this pull request as ready for review January 4, 2024 16:01

hdelan mentioned this pull request Jan 4, 2024

[SYCL][HIP][CUDA] Use new version of piMemGetNativeHandle and add test intel/llvm#12297

Merged

GeorgeWeb approved these changes Jan 12, 2024

View reviewed changes

source/adapters/hip/memory.cpp Show resolved Hide resolved

This was referenced Jan 12, 2024

[CUDA][HIP] Use device to get native context uxlfoundation/oneMath#425

Merged

[BLAS][rocBLAS] Update rocBLAS backend uxlfoundation/oneMath#428

Merged

ldrumm suggested changes Jan 12, 2024

View reviewed changes

scripts/core/memory.yml Show resolved Hide resolved

scripts/core/HIP.rst Outdated Show resolved Hide resolved

scripts/core/CUDA.rst Outdated Show resolved Hide resolved

source/adapters/hip/memory.cpp Show resolved Hide resolved

aarongreig reviewed Jan 12, 2024

View reviewed changes

scripts/core/CUDA.rst Outdated Show resolved Hide resolved

hdelan force-pushed the get-native-mem-on-device2 branch from f88620c to a52551e Compare January 12, 2024 11:47

PietroGhg approved these changes Jan 12, 2024

View reviewed changes

hdelan force-pushed the get-native-mem-on-device2 branch 2 times, most recently from a63c1e2 to 27f573e Compare January 12, 2024 12:03

hdelan force-pushed the get-native-mem-on-device2 branch from 27f573e to e141d9e Compare January 12, 2024 12:21

ldrumm approved these changes Jan 12, 2024

View reviewed changes

hdelan force-pushed the get-native-mem-on-device2 branch from d78d75f to 5c6b4ba Compare January 22, 2024 21:58

nrspruit approved these changes Jan 22, 2024

View reviewed changes

hdelan force-pushed the get-native-mem-on-device2 branch from 5c6b4ba to abf316e Compare January 23, 2024 09:10

hdelan added ready to merge Added to PR's which are ready to merge and removed ready to merge Added to PR's which are ready to merge labels Jan 23, 2024

kbenzie approved these changes Jan 30, 2024

View reviewed changes

hdelan force-pushed the get-native-mem-on-device2 branch 2 times, most recently from e4d9bfc to 5efcda5 Compare January 30, 2024 14:34

hdelan closed this Jan 30, 2024

hdelan reopened this Jan 30, 2024

Hugh Delaney added 2 commits January 30, 2024 17:26

Add extra param to urMemGetNativeHandle

8ba2a9a

Fix build for AMD

2357fbc

hdelan force-pushed the get-native-mem-on-device2 branch from c76662b to 2357fbc Compare January 30, 2024 17:27

Update match list

fc1f306

kbenzie merged commit d216eb4 into oneapi-src:main Jan 31, 2024

callumfare mentioned this pull request Jun 24, 2024

Make device param in urMemGetNativeHandle optional #1781

Closed

Conversation

hdelan commented Jan 4, 2024

Uh oh!

codecov-commenter commented Jan 4, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

hdelan commented Jan 12, 2024

Uh oh!

muhammad-tanvir-1211 commented Jan 12, 2024

Uh oh!

GeorgeWeb left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

ldrumm left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

PietroGhg left a comment

Choose a reason for hiding this comment

Uh oh!

hdelan commented Jan 12, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ldrumm commented Jan 12, 2024

Uh oh!

hdelan commented Jan 22, 2024

Uh oh!

nrspruit left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

codecov-commenter commented Jan 4, 2024 •

edited

Loading

hdelan commented Jan 12, 2024 •

edited

Loading