Make device param in urMemGetNativeHandle optional#1781
Closed
callumfare wants to merge 1 commit intooneapi-src:mainfrom
Closed
Make device param in urMemGetNativeHandle optional#1781callumfare wants to merge 1 commit intooneapi-src:mainfrom
callumfare wants to merge 1 commit intooneapi-src:mainfrom
Conversation
github-actions
bot
added
loader
hdelan
approved these changes
Jun 24, 2024
Contributor
hdelan
left a comment
hdelan
left a comment
There was a problem hiding this comment.
Sorry I should have done this in the original patch. LGTM
keyradical
approved these changes
Jun 25, 2024
aarongreig
approved these changes
Jun 25, 2024
callumfare
force-pushed
the
callum/mem_getnative_optional_device
branch
from
8d82df7 to
27e030f
Compare
Contributor
Author
|
intel-llvm PR: intel/llvm#14299 |
Merged
Contributor
Author
|
This was included in #1804 which has now merged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1226 added a device handle parameter to
urMemGetNativeHandle, but some uses in SYCL pass a null device handle, which causes unexpected failures when the validation layer is enabled, particularly for adapters where the device isn't required (OpenCL and L0).This makes the device optional, with adapters allowed to fail when given a null device if they require it to get the native handle. This should preserve the intended implementation of all the adapters, and just moves the null handle check out of the validation layer.