Conversation
github-actions
bot
added
loader
Contributor
Contributor
Author
|
These are all already approved and |
Contributor
Author
|
At least in this previous batch PR #1774 we just got an approval from Benie and then it was merged. |
Contributor
|
@hdelan I don't think we do, I'm happy to merge once tests are all passing. But obviously if anyone wants to check things before then that's ok |
this aspect is true only for sm_90 cuda gpus. Signed-off-by: JackAKirk <jack.kirk@codeplay.com>
Signed-off-by: JackAKirk <jack.kirk@codeplay.com>
Signed-off-by: Neil R. Spruit <neil.r.spruit@intel.com>
An event created with interop doesn't have an associated queue. So get an active device through the context.
get_program is the same as getProgram.
We can only call hipMemAdvise on managed pointers allocated via hipMallocManaged, so can only support the UR entry point on pointers allocated via urUSMSharedAlloc. When faced with other pointers, we're supposed to ignore them and result "success", but instead this PR continues the tradition of returning UR_RESULT_ERROR_ADAPTER_SPECIFIC with a warning message providing the user more information. This should all be fixed up later when there's a better warning mechanism.
set property cudaFuncAttributeNonPortableClusterSizeAllowed only if cluster launch is used set has_property_cluster_launch only if cluster property is used fix cluster dimensions being set in accordance to grid dimensions fix ordering of cluster dims for workDim 2 fix compilation errors review comments 1 review comments 1 increase cluster size upon launch to check CU_FUNC_ATTRIBUTE_NON_PORTABLE_CLUSTER_SIZE_ALLOWED flag being added
- Fix incorrect conditions for copy engine usage that were reported on coverity.
Contributor
Author
|
I have squashed #1765 |
Contributor
|
The CI jobs all passed before the commits from #1765 were squashed, and the intel/llvm pipeline passed, so I'm merging this now rather than waiting for them to rerun |
This was referenced Jun 28, 2024
martygrant
pushed a commit
to intel/llvm
that referenced
this pull request
Jul 1, 2024
oneapi-src/unified-runtime#1804 --------- Co-authored-by: Callum Fare <callum@codeplay.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Batch merge of PRs:
#1792
#1787
#1782
#1783
#1781
#1773
#1765
#1763