[UR][HIP][CUDA] Batched Changes#1774
Merged
kbenzie merged 21 commits intooneapi-src:mainfrom Jun 20, 2024
Merged
Conversation
When allocating new managed memory. Signed-off-by: JackAKirk <jack.kirk@codeplay.com>
Covers case where command device outside the ur Context. Signed-off-by: JackAKirk <jack.kirk@codeplay.com>
Signed-off-by: JackAKirk <jack.kirk@codeplay.com>
Signed-off-by: JackAKirk <jack.kirk@codeplay.com>
Use unique ptrs, and have the destructor call clear(), instead of calling it manually. Also add a case for a std::bad_alloc.
If new fails then std::bad_alloc will be thrown. Also add the same checking for urMemBufferCreate.
Make sure all calls of new in try catch which can catch a bad_alloc.
Make all calls to `new` safe in HIP adapter.
We can't make assumptions about interop events being on the same stream as other interop events, since in UR we don't track the streams that native events are recorded on.
The property should be of type size_t. Note that we're removing a bunch of match lines for seemingly unrelated properties, but in fact the CTS tests do not make use of the parameter they claim, and in fact hard-code the UR_KERNEL_INFO_NUM_ARGS property.
Mirrors a similar change made to the CUDA adapater in 00761dc.
We were always returning the maximum log size (of 8192) even when the actual log was much shorter. Strictly speaking, we should be returning the log only up to the first null terminator. Doing otherwise could cause strange behaviour, and may account for the flaky fails we've seen in this test on both adapters.
The HIP and CUDA adapaters would like a more verbose logging level by default. This patch allows customization per logger. If the default log level is unsupplied, the old default continues to be used. Users can also continue to override the logging level via the various environment variables.
kbenzie
approved these changes
Jun 19, 2024
github-actions
bot
added
common
hdelan
force-pushed
the
readytomerge-branch
branch
from
ae71aaf to
4929481
Compare
added 3 commits
June 19, 2024 16:05
…aser/hip-context-native-handle', 'origin/fix-interop-event-bug', 'origin/make-imagecreate-safe' and 'Jack/cuda-malloc-managed-optimize' into readytomerge-branch
hdelan
force-pushed
the
readytomerge-branch
branch
from
4929481 to
836056e
Compare
kbenzie
changed the title
martygrant
pushed a commit
to intel/llvm
that referenced
this pull request
Jun 21, 2024
oneapi-src/unified-runtime#1774 --------- Co-authored-by: Kenneth Benzie (Benie) <k.benzie@codeplay.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using PRs:
newfailsafe #1752ur_context_handle_tfor managed memory #1717