[CUDA][HIP] Fix build info log reporting#1725
Merged
kbenzie merged 1 commit intooneapi-src:mainfrom Jun 20, 2024
Merged
Conversation
frasercrmck
force-pushed
the
fix-build-info-log
branch
from
288bfb9 to
88433f3
Compare
github-actions
bot
added
conformance
frasercrmck
force-pushed
the
fix-build-info-log
branch
from
88433f3 to
87ddf67
Compare
frasercrmck
force-pushed
the
fix-build-info-log
branch
4 times, most recently
from
e7814a1 to
d6ac983
Compare
We were always returning the maximum log size (of 8192) even when the actual log was much shorter. Strictly speaking, we should be returning the log only up to the first null terminator. Doing otherwise could cause strange behaviour, and may account for the flaky fails we've seen in this test on both adapters.
frasercrmck
force-pushed
the
fix-build-info-log
branch
from
d6ac983 to
8b495ad
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We were always returning the maximum log size (of 8192) even when the actual log was much shorter. Strictly speaking, we should be returning the log only up to the first null terminator. Doing otherwise could cause strange behaviour, and may account for the flaky fails we've seen in this test on both adapters.