[HIP] Fix return type for urKernelGetInfo UR_KERNEL_INFO_NUM_ARGS#1766
Merged
kbenzie merged 1 commit intooneapi-src:mainfrom Jun 20, 2024
Merged
[HIP] Fix return type for urKernelGetInfo UR_KERNEL_INFO_NUM_ARGS#1766kbenzie merged 1 commit intooneapi-src:mainfrom
kbenzie merged 1 commit intooneapi-src:mainfrom
Conversation
JackAKirk
approved these changes
Jun 17, 2024
github-actions
bot
added
conformance
aarongreig
approved these changes
Jun 18, 2024
frasercrmck
changed the title
The property should be of type size_t. Note that we're removing a bunch of match lines for seemingly unrelated properties, but in fact the CTS tests do not make use of the parameter they claim, and in fact hard-code the UR_KERNEL_INFO_NUM_ARGS property.
frasercrmck
force-pushed
the
hip-kernel-info-num-args
branch
from
72836ae to
c31ac7c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The property should be of type size_t.
Note that we're removing a bunch of match lines for seemingly unrelated properties, but in fact the CTS tests do not make use of the parameter they claim, and in fact hard-code the UR_KERNEL_INFO_NUM_ARGS property.